@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Persisent an open form when actively running queries
Summary: Ref T8099, Adds ability to set hidden form open, which leaves form open on searches and moves anchor point.
Test Plan: Run saved searches, advanced searches, and searches from main search ui.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13308
authored by
Chad Little
and committed by
epriestley
13e95928
3846a009
+13
-10
+2
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
+2
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
193
193
pht('Edit Query'),
194
194
pht('Hide Query'),
195
195
$form,
196
-
$this->getApplicationURI('query/advanced/?query='.$query_key));
196
+
$this->getApplicationURI('query/advanced/?query='.$query_key),
197
+
(!$named_query ? true : false));
197
198
} else {
198
199
$box->setForm($form);
199
200
}
+10
-4
src/view/phui/PHUIObjectBoxView.php
+10
-4
src/view/phui/PHUIObjectBoxView.php
···
24
24
private $hideAction;
25
25
private $showHideHref;
26
26
private $showHideContent;
27
+
private $showHideOpen;
27
28
28
29
private $tabs = array();
29
30
private $propertyLists = array();
···
173
174
return $this;
174
175
}
175
176
176
-
public function setShowHide($show, $hide, $content, $href) {
177
+
public function setShowHide($show, $hide, $content, $href, $open = false) {
177
178
$this->showAction = $show;
178
179
$this->hideAction = $hide;
179
180
$this->showHideContent = $content;
180
181
$this->showHideHref = $href;
182
+
$this->showHideOpen = $open;
181
183
return $this;
182
184
}
183
185
···
205
207
$show_action_id = celerity_generate_unique_node_id();
206
208
$content_id = celerity_generate_unique_node_id();
207
209
210
+
$hide_style = ($this->showHideOpen ? 'display: none;': null);
211
+
$show_style = ($this->showHideOpen ? null : 'display: none;');
208
212
$hide_action = id(new PHUIButtonView())
209
213
->setTag('a')
210
214
->addSigil('reveal-content')
211
215
->setID($hide_action_id)
216
+
->setStyle($hide_style)
212
217
->setHref($this->showHideHref)
213
218
->setMetaData(
214
219
array(
···
220
225
$show_action = id(new PHUIButtonView())
221
226
->setTag('a')
222
227
->addSigil('reveal-content')
223
-
->setStyle('display: none;')
228
+
->setStyle($show_style)
224
229
->setHref('#')
225
230
->setID($show_action_id)
226
231
->setMetaData(
···
239
244
array(
240
245
'class' => 'phui-object-box-hidden-content',
241
246
'id' => $content_id,
242
-
'style' => 'display: none;',
247
+
'style' => $show_style,
243
248
),
244
249
$this->showHideContent),
245
250
);
···
352
357
$content = id(new PHUIBoxView())
353
358
->appendChild(
354
359
array(
355
-
$this->anchor,
360
+
($this->showHideOpen == false ? $this->anchor : null),
356
361
$header,
357
362
$this->infoView,
358
363
$this->formErrors,
···
362
367
$tabs,
363
368
$tab_lists,
364
369
$showhide,
370
+
($this->showHideOpen == true ? $this->anchor : null),
365
371
$property_lists,
366
372
$this->table,
367
373
$this->renderChildren(),
+1
webroot/rsrc/css/application/search/search-results.css
+1
webroot/rsrc/css/application/search/search-results.css
-5
webroot/rsrc/css/phui/phui-header-view.css
-5
webroot/rsrc/css/phui/phui-header-view.css