@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a Maniphest issue where multiple saved copies of a query break the menu
Summary: Fixes T2210. Recently, we require unique keys on menu items, but it's currently possible in Maniphest to save the same custom query under multiple names. Avoid exploding in this case (we'll hide the duplicates). This isn't a great fix, but makes Maniphest usable again.
Test Plan: Saved the same query twice, laoded page, got exception, applied patch, loaded page, saw duplicate query stripped.
Reviewers: btrahan, vrana
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2210
Differential Revision: https://secure.phabricator.com/D4247
+6
+6
src/applications/maniphest/controller/ManiphestController.php
+6
src/applications/maniphest/controller/ManiphestController.php
···
33
33
'userPHID = %s ORDER BY isDefault DESC, name ASC',
34
34
$user->getPHID());
35
35
36
+
// TODO: Enforce uniqueness. Currently, it's possible to save the same
37
+
// query under multiple names, and then SideNavFilterView explodes on
38
+
// duplicate keys. Generally, we should clean up the custom/saved query
39
+
// code as it's a bit of a mess.
40
+
$custom = mpull($custom, null, 'getQueryKey');
41
+
36
42
if ($custom) {
37
43
$nav->addLabel('Saved Queries');
38
44
foreach ($custom as $query) {