@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Give Phriction documents modern string status constants instead of numeric constants
Summary:
Depends on D19099. Ref T13077. Updates Phriction documents to string constants to make API interactions cleaner and statuses more practical to extend.
This does not seem to require any transaction migrations because none of the Phriction transactions actually store status values: status is always a side effect of other edits.
Test Plan: Created, edited, deleted, moved documents. Saw appropriate UI cues. Browsed and filtered documents by status in the index.
Maniphest Tasks: T13077
Differential Revision: https://secure.phabricator.com/D19100
+19
-6
+2
resources/sql/autopatches/20180215.phriction.05.statustext.sql
+2
resources/sql/autopatches/20180215.phriction.05.statustext.sql
+11
resources/sql/autopatches/20180215.phriction.06.statusvalue.sql
+11
resources/sql/autopatches/20180215.phriction.06.statusvalue.sql
···
1
+
UPDATE {$NAMESPACE}_phriction.phriction_document
2
+
SET status = 'active' WHERE status = '0';
3
+
4
+
UPDATE {$NAMESPACE}_phriction.phriction_document
5
+
SET status = 'deleted' WHERE status = '1';
6
+
7
+
UPDATE {$NAMESPACE}_phriction.phriction_document
8
+
SET status = 'moved' WHERE status = '2';
9
+
10
+
UPDATE {$NAMESPACE}_phriction.phriction_document
11
+
SET status = 'stub' WHERE status = '3';
+4
-4
src/applications/phriction/constants/PhrictionDocumentStatus.php
+4
-4
src/applications/phriction/constants/PhrictionDocumentStatus.php
···
3
3
final class PhrictionDocumentStatus
4
4
extends PhabricatorObjectStatus {
5
5
6
-
const STATUS_EXISTS = 0;
7
-
const STATUS_DELETED = 1;
8
-
const STATUS_MOVED = 2;
9
-
const STATUS_STUB = 3;
6
+
const STATUS_EXISTS = 'active';
7
+
const STATUS_DELETED = 'deleted';
8
+
const STATUS_MOVED = 'moved';
9
+
const STATUS_STUB = 'stub';
10
10
11
11
public static function getConduitConstant($const) {
12
12
static $map = array(
+1
-1
src/applications/phriction/query/PhrictionDocumentQuery.php
+1
-1
src/applications/phriction/query/PhrictionDocumentQuery.php