@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an incorrectly spelled call on the registration error pathway
Summary: If you copy the registration URL, then register, then load the URL again while logged out (i.e., attempt to reuse the registration URL), we try to show you a tailored error message. However, this call is not correct so we show you a not-so tailored exception instead.
Test Plan:
- Get to the registration screen.
- Save URL.
- Complete registration.
- Log out.
- Return to saved URL.
Previously, exception. Now, readable error.
{F117585}
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D8322
+1
-1
+1
-1
src/applications/auth/controller/PhabricatorAuthController.php
+1
-1
src/applications/auth/controller/PhabricatorAuthController.php
···
158
158
}
159
159
160
160
if ($account->getUserPHID()) {
161
-
if ($account->getUserPHID() != $viewer->getUserPHID()) {
161
+
if ($account->getUserPHID() != $viewer->getPHID()) {
162
162
$response = $this->renderError(
163
163
pht(
164
164
'The account you are attempting to register or link is already '.