@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve "Ignore" action for setup warnings
Summary:
- The dialog has no body text.
- It uses an "Ignore" link because it predates action items.
Test Plan:
{F49894}
{F49895}
{F49896}
Reviewers: chad, btrahan
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D6433
+27
-20
+15
-7
src/applications/config/controller/PhabricatorConfigIgnoreController.php
+15
-7
src/applications/config/controller/PhabricatorConfigIgnoreController.php
···
20
20
return id(new AphrontRedirectResponse())->setURI($issue_uri);
21
21
}
22
22
23
-
// User just clicked the link, so show them the dialog.
24
23
if ($this->verb == 'ignore') {
25
24
$title = pht('Really ignore this setup issue?');
26
25
$submit_title = pht('Ignore');
26
+
$body = pht(
27
+
"You can ignore an issue if you don't want to fix it, or plan to ".
28
+
"fix it later. Ignored issues won't appear on every page but will ".
29
+
"still be shown in the list of open issues.");
27
30
} else if ($this->verb == 'unignore') {
28
-
$title = pht('Really unignore this setup issue?');
31
+
$title = pht('Unignore this setup issue?');
29
32
$submit_title = pht('Unignore');
33
+
$body = pht(
34
+
"This issue will no longer be suppressed, and will return to its ".
35
+
"rightful place as a global setup warning.");
30
36
} else {
31
37
throw new Exception('Unrecognized verb: ' . $this->verb);
32
38
}
33
-
$dialog = new AphrontDialogView();
34
-
$dialog->setTitle($title)
35
-
->setUser($request->getUser())
36
-
->addSubmitButton($submit_title)
37
-
->addCancelButton($issue_uri);
39
+
40
+
$dialog = id(new AphrontDialogView())
41
+
->setUser($request->getUser())
42
+
->setTitle($title)
43
+
->appendChild($body)
44
+
->addSubmitButton($submit_title)
45
+
->addCancelButton($issue_uri);
38
46
39
47
return id(new AphrontDialogResponse())->setDialog($dialog);
40
48
}
+12
-13
src/applications/config/controller/PhabricatorConfigIssueListController.php
+12
-13
src/applications/config/controller/PhabricatorConfigIssueListController.php
···
58
58
->setHref($href)
59
59
->addAttribute($issue->getSummary());
60
60
if (!$issue->getIsIgnored()) {
61
-
$item->addIcon('warning', pht('Setup Warning'));
62
-
$link = javelin_tag(
63
-
'a',
64
-
array('href' => '/config/ignore/'.$issue->getIssueKey().'/',
65
-
'sigil' => 'workflow'),
66
-
pht('Ignore'));
67
61
$item->setBarColor('yellow');
68
-
$item->addAttribute($link);
62
+
$item->addAction(
63
+
id(new PHUIListItemView())
64
+
->setIcon('unpublish')
65
+
->setWorkflow(true)
66
+
->setName(pht('Ignore'))
67
+
->setHref('/config/ignore/'.$issue->getIssueKey().'/'));
69
68
$list->addItem($item);
70
69
} else {
71
70
$item->addIcon('none', pht('Ignored'));
72
-
$link = javelin_tag(
73
-
'a',
74
-
array('href' => '/config/unignore/'.$issue->getIssueKey().'/',
75
-
'sigil' => 'workflow'),
76
-
pht('Unignore'));
77
-
$item->addAttribute($link);
71
+
$item->addAction(
72
+
id(new PHUIListItemView())
73
+
->setIcon('preview')
74
+
->setWorkflow(true)
75
+
->setName(pht('Unignore'))
76
+
->setHref('/config/unignore/'.$issue->getIssueKey().'/'));
78
77
$item->setBarColor('none');
79
78
$ignored_items[] = $item;
80
79
}