@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Emit resize events after making document changes during inline editing
Summary:
Ref T12634. Fixes T12633. These events allow the keyboard reticle to resize properly.
(I expect to possibly hide/disable the reticle in the future during edits, but at least make the behavior sensible for now.)
Test Plan:
- Used "n" to select a block.
- Clicked a line number in that block to start a new inline comment.
- Saw reticle resize properly.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12634, T12633
Differential Revision: https://secure.phabricator.com/D17904
+12
-6
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
13
13
'core.pkg.js' => '8c5f913d',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '58712637',
16
-
'differential.pkg.js' => 'a185599e',
16
+
'differential.pkg.js' => '6ee9a850',
17
17
'diffusion.pkg.css' => 'b93d9b8c',
18
18
'diffusion.pkg.js' => '84c8f8fd',
19
19
'favicon.ico' => '30672e08',
···
392
392
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
393
393
'rsrc/js/application/diff/DiffChangeset.js' => 'f7100923',
394
394
'rsrc/js/application/diff/DiffChangesetList.js' => 'e5c5e171',
395
-
'rsrc/js/application/diff/DiffInline.js' => 'f3af20b1',
395
+
'rsrc/js/application/diff/DiffInline.js' => '4bbefc49',
396
396
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
397
397
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
398
398
'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76',
···
783
783
'phabricator-dashboard-css' => 'fe5b1869',
784
784
'phabricator-diff-changeset' => 'f7100923',
785
785
'phabricator-diff-changeset-list' => 'e5c5e171',
786
-
'phabricator-diff-inline' => 'f3af20b1',
786
+
'phabricator-diff-inline' => '4bbefc49',
787
787
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
788
788
'phabricator-draggable-list' => 'bea6e7f4',
789
789
'phabricator-fatal-config-template-css' => '8f18fa41',
···
1259
1259
'javelin-util',
1260
1260
'phabricator-shaped-request',
1261
1261
),
1262
+
'4bbefc49' => array(
1263
+
'javelin-dom',
1264
+
),
1262
1265
'4c193c96' => array(
1263
1266
'javelin-behavior',
1264
1267
'javelin-uri',
···
2169
2172
'javelin-util',
2170
2173
'javelin-workflow',
2171
2174
'javelin-json',
2172
-
),
2173
-
'f3af20b1' => array(
2174
-
'javelin-dom',
2175
2175
),
2176
2176
'f50152ad' => array(
2177
2177
'phui-timeline-view-css',
+6
webroot/rsrc/js/application/diff/DiffInline.js
+6
webroot/rsrc/js/application/diff/DiffInline.js
···
438
438
row = next_row;
439
439
}
440
440
441
+
JX.Stratcom.invoke('resize');
442
+
441
443
return first_meta;
442
444
},
443
445
···
516
518
// After making changes to inline comments, refresh the transaction
517
519
// preview at the bottom of the page.
518
520
this.getChangeset().getChangesetList().redrawPreview();
521
+
522
+
// Emit a resize event so that UI elements like the keyboad focus
523
+
// reticle can redraw properly.
524
+
JX.Stratcom.invoke('resize');
519
525
},
520
526
521
527
_redraw: function() {