recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Only return description in Policy description if no image required

Summary: We were returning an array here when previous return was a string.

Test Plan: reload diff

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D7025

Chad Little 14aa70a2 cd4cb121

+6 -4
+1 -3
src/applications/differential/field/specification/DifferentialDiffViewPolicyFieldSpecification.php
··· 19 19 $user, 20 20 $diff); 21 21 22 - // TODO: Clean this up with new policy UI. 23 - $policy = idx($descriptions, PhabricatorPolicyCapability::CAN_VIEW); 24 - return $policy[1]; 22 + return idx($descriptions, PhabricatorPolicyCapability::CAN_VIEW); 25 23 } 26 24 27 25 }
+5 -1
src/applications/policy/filter/PhabricatorPolicy.php
··· 161 161 $this->getName(), 162 162 )); 163 163 } else { 164 - $desc = array($img, $this->getName()); 164 + if ($img) { 165 + $desc = array($img, $this->getName()); 166 + } else { 167 + $desc = $this->getName(); 168 + } 165 169 } 166 170 167 171 switch ($this->getType()) {