recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix bad array index test in Differential package code

Summary: This needs an `isset()` for cases when authority and packages don't completely overlap.

Test Plan:
- With a package set to trigger autoreview, created a revision.
- Observed error log, saw no more error.
- Saw package trigger autoreview properly.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16398

epriestley 15021a0b 8c412266

+1 -1
+1 -1
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 1533 1533 1534 1534 foreach ($packages as $key => $package) { 1535 1535 $package_phid = $package->getPHID(); 1536 - if ($authority[$package_phid]) { 1536 + if (isset($authority[$package_phid])) { 1537 1537 unset($packages[$key]); 1538 1538 continue; 1539 1539 }