@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor UI improvements for Harbormaster
Summary: Ref T1049. Makes some minor UI tweaks.
Test Plan: Looked at UI.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T1049
Differential Revision: https://secure.phabricator.com/D8587
+5
-6
+1
-1
src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php
+1
-1
src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php
···
58
58
=> 'HarbormasterBuildableActionController',
59
59
),
60
60
'build/' => array(
61
-
'(?:(?P<id>\d+)/)?' => 'HarbormasterBuildViewController',
61
+
'(?P<id>\d+)/' => 'HarbormasterBuildViewController',
62
62
'(?P<action>stop|resume|restart)/(?P<id>\d+)/(?:(?P<via>[^/]+)/)?'
63
63
=> 'HarbormasterBuildActionController',
64
64
),
+4
-5
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+4
-5
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
···
28
28
->withObjectPHIDs(array($plan->getPHID()))
29
29
->execute();
30
30
31
-
$engine = id(new PhabricatorMarkupEngine())
32
-
->setViewer($viewer);
33
-
34
31
$xaction_view = id(new PhabricatorApplicationTransactionView())
35
32
->setUser($viewer)
36
33
->setObjectPHID($plan->getPHID())
37
34
->setTransactions($xactions)
38
-
->setMarkupEngine($engine);
35
+
->setShouldTerminate(true);
39
36
40
37
$title = pht("Plan %d", $id);
41
38
···
85
82
$i = 1;
86
83
$step_list = id(new PHUIObjectItemListView())
87
84
->setUser($viewer)
85
+
->setNoDataString(
86
+
pht('This build plan does not have any build steps yet.'))
88
87
->setID($list_id);
89
88
Javelin::initBehavior(
90
89
'harbormaster-reorder-steps',
···
100
99
// We can't initialize the implementation. This might be because
101
100
// it's been renamed or no longer exists.
102
101
$item = id(new PHUIObjectItemView())
103
-
->setObjectName("Step ".$i++)
102
+
->setObjectName(pht('Step %d', $i++))
104
103
->setHeader(pht('Unknown Implementation'))
105
104
->setBarColor('red')
106
105
->addAttribute(pht(