recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show node IDs in XHPAST tree view

Summary: Currently we do not show node IDs in this view, but do show token IDs in the stream view. Given that this view facilitates testing various XHPAST functionality, it would be useful to add this information.

Test Plan: Saw node IDs in XHPAST.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14697

Joshua Spence 15550b55 8752bd49

+2 -2
+1 -1
src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php
··· 22 22 foreach ($tree->getRawTokenStream() as $id => $token) { 23 23 $seq = $id; 24 24 $name = $token->getTypeName(); 25 - $title = pht('Token %s: %s', $seq, $name); 25 + $title = pht('Token %d: %s', $seq, $name); 26 26 27 27 $tokens[] = phutil_tag( 28 28 'span',
+1 -1
src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php
··· 29 29 protected function buildTree($root) { 30 30 try { 31 31 $name = $root->getTypeName(); 32 - $title = $root->getDescription(); 32 + $title = pht('Node %d: %s', $root->getID(), $name); 33 33 } catch (Exception $ex) { 34 34 $name = '???'; 35 35 $title = '???';