@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct transaction strengths after inconsitent scaling by 100 vs 1000
Summary:
See D20540. I mistakenly multiplied some strenghts by 100 and others by 1000 when converting them to integers for `PhutilSortVector`.
Multiply them all by 100 (that is, divide the ones which were multiplied by 1000 by 10) to put things back the way they were.
Test Plan: quick mafs
Reviewers: amckinley, richardvanvelzen
Reviewed By: richardvanvelzen
Differential Revision: https://secure.phabricator.com/D20622
+6
-6
+6
-6
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+6
-6
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
1375
1375
1376
1376
public function getActionStrength() {
1377
1377
if ($this->isInlineCommentTransaction()) {
1378
-
return 250;
1378
+
return 25;
1379
1379
}
1380
1380
1381
1381
switch ($this->getTransactionType()) {
1382
1382
case PhabricatorTransactions::TYPE_COMMENT:
1383
-
return 500;
1383
+
return 50;
1384
1384
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
1385
1385
if ($this->isSelfSubscription()) {
1386
1386
// Make this weaker than TYPE_COMMENT.
1387
-
return 250;
1387
+
return 25;
1388
1388
}
1389
1389
1390
1390
if ($this->isApplicationAuthor()) {
···
1396
1396
// In other cases, subscriptions are more interesting than comments
1397
1397
// (which are shown anyway) but less interesting than any other type of
1398
1398
// transaction.
1399
-
return 750;
1399
+
return 75;
1400
1400
case PhabricatorTransactions::TYPE_MFA:
1401
1401
// We want MFA signatures to render at the top of transaction groups,
1402
1402
// on top of the things they signed.
1403
-
return 10000;
1403
+
return 1000;
1404
1404
}
1405
1405
1406
-
return 1000;
1406
+
return 100;
1407
1407
}
1408
1408
1409
1409
public function isCommentTransaction() {