@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix almanac.queryservices for no results
Summary: Ref T5833. We try to load bindings even if we get no services back.
Test Plan: Queried invalid results.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T5833
Differential Revision: https://secure.phabricator.com/D10880
+9
-5
+9
-5
src/applications/almanac/conduit/AlmanacQueryServicesConduitAPIMethod.php
+9
-5
src/applications/almanac/conduit/AlmanacQueryServicesConduitAPIMethod.php
···
52
52
53
53
$services = $query->executeWithCursorPager($pager);
54
54
55
-
$bindings = id(new AlmanacBindingQuery())
56
-
->setViewer($viewer)
57
-
->withServicePHIDs(mpull($services, 'getPHID'))
58
-
->execute();
59
-
$bindings = mgroup($bindings, 'getServicePHID');
55
+
if ($services) {
56
+
$bindings = id(new AlmanacBindingQuery())
57
+
->setViewer($viewer)
58
+
->withServicePHIDs(mpull($services, 'getPHID'))
59
+
->execute();
60
+
$bindings = mgroup($bindings, 'getServicePHID');
61
+
} else {
62
+
$bindings = array();
63
+
}
60
64
61
65
$data = array();
62
66
foreach ($services as $service) {