recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix improper viewer for Git SSH cluster workflows

Summary: Ref T10751. These workflows have separate `getUser()` and `getViewer()` for weird legacy reasons. `getUser()` is correct.

Test Plan:
- Did a Git SSH push, verified that "Last Writer" reflected the proper user in the "Storage" UI in repository management.
- Grepped for other callsites, double-checked that they used correct users.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10751

Differential Revision: https://secure.phabricator.com/D15893

epriestley 15f14d6c 54409e77

+1 -1
+1 -1
src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php
··· 15 15 16 16 protected function executeRepositoryOperations() { 17 17 $repository = $this->getRepository(); 18 - $viewer = $this->getViewer(); 18 + $viewer = $this->getUser(); 19 19 $device = AlmanacKeys::getLiveDevice(); 20 20 21 21 // This is a write, and must have write access.