@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix watcher query to work correctly with no watchers.
+16
-15
+16
-15
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+16
-15
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
1922
1922
$query->execute();
1923
1923
1924
1924
$watcher_phids = $query->getDestinationPHIDs();
1925
+
if ($watcher_phids) {
1926
+
// We need to do a visibility check for all the watchers, as
1927
+
// watching a project is not a guarantee that you can see objects
1928
+
// associated with it.
1929
+
$users = id(new PhabricatorPeopleQuery())
1930
+
->setViewer($this->requireActor())
1931
+
->withPHIDs($watcher_phids)
1932
+
->execute();
1925
1933
1926
-
// We need to do a visibility check for all the watchers, as
1927
-
// watching a project is not a guarantee that you can see objects
1928
-
// associated with it.
1929
-
$users = id(new PhabricatorPeopleQuery())
1930
-
->setViewer($this->requireActor())
1931
-
->withPHIDs($watcher_phids)
1932
-
->execute();
1933
-
1934
-
foreach ($users as $user) {
1935
-
$can_see = PhabricatorPolicyFilter::hasCapability(
1936
-
$user,
1937
-
$object,
1938
-
PhabricatorPolicyCapability::CAN_VIEW);
1939
-
if ($can_see) {
1940
-
$phids[] = $user->getPHID();
1934
+
foreach ($users as $user) {
1935
+
$can_see = PhabricatorPolicyFilter::hasCapability(
1936
+
$user,
1937
+
$object,
1938
+
PhabricatorPolicyCapability::CAN_VIEW);
1939
+
if ($can_see) {
1940
+
$phids[] = $user->getPHID();
1941
+
}
1941
1942
}
1942
1943
}
1943
1944
}