@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
STRICT_ALL_TABLES fix for a Herald column
Summary: Casting a PHP bool to a MySQL `TINYINT(1)`!
Test Plan: This broke during arc diff; with this patch, arc diff now works!
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4999
+1
-1
+1
-1
src/applications/herald/engine/HeraldEngine.php
+1
-1
src/applications/herald/engine/HeraldEngine.php
···
110
110
assert_instances_of($effects, 'HeraldEffect');
111
111
assert_instances_of($rules, 'HeraldRule');
112
112
113
-
$this->transcript->setDryRun($object instanceof HeraldDryRunAdapter);
113
+
$this->transcript->setDryRun((int)($object instanceof HeraldDryRunAdapter));
114
114
115
115
$xscripts = $object->applyHeraldEffects($effects);
116
116
foreach ($xscripts as $apply_xscript) {