@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

a11y: Do not mark top bar notifications area as aria-hidden

Summary:
Do not the mark main alerts/notifications area as aria-hidden.
Focusable descendents within an [aria-hidden="true"] element prevent those interactive elements from being available to users of assistive technologies like screen readers.

As can be seen in the code of `PhabricatorMainMenuView`, all three icons already define some `$aural[]` array to include output for assistive technologies, so their parent element should not block accessing that output.

Ref T16072

Test Plan:
* Go to http://phorge.localhost/ and inspect the `<div class="phabricator-main-menu-alerts">` element and its descendents.
* Ideally, check with some screenreader sofware. I didn't.
* Optionally, run an Accessibility check in Chromium Lighthouse.

Reviewers: O1 Blessed Committers, chris

Reviewed By: O1 Blessed Committers, chris

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16072

Differential Revision: https://we.phorge.it/D26053

-1
-1
src/view/page/menu/PhabricatorMainMenuView.php
··· 88 88 'div', 89 89 array( 90 90 'class' => 'phabricator-main-menu-alerts', 91 - 'aural' => false, 92 91 ), 93 92 $alerts); 94 93 }