recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove `break` from hunk migration

Summary: This `break` statement causes `./bin/hunks migrate` to only migrate one-hunk-at-a-time, which is unnecessary and slightly misleading. Instead, allow the script to migrate //all// legacy hunks to modern storage. In particular, this means that we can recommend that installs run this command sometime before D13222 is landed.

Test Plan: It's a pain to setup the data necessary to test this, but this is identical to the change that I made on our production install when I migrated our hunk storage.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13288

Joshua Spence 175799fa 32f4c962

-2
-2
src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php
··· 48 48 new PhutilNumber($diff_len), 49 49 sprintf('%.1f%%', 100 * ($diff_len / $old_len)))); 50 50 } 51 - 52 - break; 53 51 } 54 52 55 53 if ($saw_any_rows) {