@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Treat keyCode 10 as "return" in JX.Event
Summary: Fixes T2753. Return is sent as either 10 or 13, depending on browser and OS. See, e.g. [[ http://code.google.com/p/chromium/issues/detail?id=79407 | this Chromium issue ]].
Test Plan: @cystorm confirmed this patch fixes the issue on his system.
Reviewers: btrahan, codeblock
Reviewed By: codeblock
CC: cystorm, aran
Maniphest Tasks: T2753
Differential Revision: https://secure.phabricator.com/D5381
+4
+4
externals/javelinjs/src/core/Event.js
+4
externals/javelinjs/src/core/Event.js
···
229
229
_keymap : {
230
230
8 : 'delete',
231
231
9 : 'tab',
232
+
// On Windows and Linux, Chrome sends '10' for return. On Mac OS X, it
233
+
// sends 13. Other browsers evidence varying degrees of diversity in their
234
+
// behavior. Treat '10' and '13' identically.
235
+
10 : 'return',
232
236
13 : 'return',
233
237
27 : 'esc',
234
238
37 : 'left',