recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PhabricatorProjectCustomFields to use storage correctly.

Summary: Prevents infinite recursion when trying to save custom fields on projects.

Test Plan: Add a custom field (that is a class, not one configured in the UI) to a project, and try to save it.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Projects: #phabricator

Maniphest Tasks: T5606

Differential Revision: https://secure.phabricator.com/D9908

authored by

Michael Peters and committed by
epriestley 17badfac b7a97059

+11
+11
src/applications/project/customfield/PhabricatorProjectCustomField.php
··· 3 3 abstract class PhabricatorProjectCustomField 4 4 extends PhabricatorCustomField { 5 5 6 + public function newStorageObject() { 7 + return new PhabricatorProjectCustomFieldStorage(); 8 + } 9 + 10 + protected function newStringIndexStorage() { 11 + return new PhabricatorProjectCustomFieldStringIndex(); 12 + } 13 + 14 + protected function newNumericIndexStorage() { 15 + return new PhabricatorProjectCustomFieldNumericIndex(); 16 + } 6 17 7 18 }