@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf
Summary:
Explicitly mentioning PHP5 packages is outdated and confusing.
Also, mentioning dnf together with yum (apparently yum is still in use!). Good for yum users.
Closes T15352
Test Plan: Applied this change and strings on the "Missing Required Extensions" page rendered as expected.
Reviewers: O1 Blessed Committers, valerio.bozzolan, jgleeson
Reviewed By: O1 Blessed Committers, valerio.bozzolan, jgleeson
Subscribers: jgleeson, bfs, speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15352
Differential Revision: https://we.phorge.it/D25203
+9
-7
+9
-7
src/applications/config/view/PhabricatorSetupIssueView.php
+9
-7
src/applications/config/view/PhabricatorSetupIssueView.php
···
73
73
'Install these %d PHP extension(s):', count($extensions));
74
74
75
75
$install_info = pht(
76
-
'You can usually install a PHP extension using %s or %s. Common '.
77
-
'package names are %s or %s. Try commands like these:',
76
+
'You can usually install a PHP extension using %s, %s, or %s. A '.
77
+
'common package name is %s. Try commands like these:',
78
78
phutil_tag('tt', array(), 'apt-get'),
79
+
phutil_tag('tt', array(), 'dnf'),
79
80
phutil_tag('tt', array(), 'yum'),
80
-
hsprintf('<tt>php-<em>%s</em></tt>', pht('extname')),
81
-
hsprintf('<tt>php5-<em>%s</em></tt>', pht('extname')));
81
+
hsprintf('<tt>php-<em>%s</em></tt>', pht('extname')));
82
82
83
83
// TODO: We should do a better job of detecting how to install extensions
84
84
// on the current system.
85
85
$install_commands = hsprintf(
86
-
"\$ sudo apt-get install php5-<em>extname</em> ".
86
+
"\$ sudo apt-get install php-<em>extname</em> ".
87
87
"# Debian / Ubuntu\n".
88
-
"\$ sudo yum install php-<em>extname</em> ".
89
-
"# Red Hat / Derivatives");
88
+
"\$ sudo dnf install php-<em>extname</em> ".
89
+
"# Red Hat / Derivatives\n".
90
+
"\$ sudo yum install php-<em>extname</em> ".
91
+
"# Older Red Hat versions");
90
92
91
93
$fallback_info = pht(
92
94
"If those commands don't work, try Google. The process of installing ".