@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make some dropdown CSS more specific
Summary:
Dropdowns have some `span` rules and such currently. Give them class-based rules instead.
(This allows me to add another <span> to menu items later on without it picking up silly styles.)
Test Plan: In a future diff, added menu items with additional <span>s inside them.
Reviewers: btrahan, chad
Reviewed By: chad
CC: chad, aran
Differential Revision: https://secure.phabricator.com/D7294
+104
-94
+88
-88
src/__celerity_resource_map__.php
+88
-88
src/__celerity_resource_map__.php
···
3299
3299
),
3300
3300
'phabricator-menu-item' =>
3301
3301
array(
3302
-
'uri' => '/res/345d4168/rsrc/js/core/DropdownMenuItem.js',
3302
+
'uri' => '/res/e810b0a1/rsrc/js/core/DropdownMenuItem.js',
3303
3303
'type' => 'js',
3304
3304
'requires' =>
3305
3305
array(
···
3770
3770
),
3771
3771
'phui-button-css' =>
3772
3772
array(
3773
-
'uri' => '/res/3be4ec80/rsrc/css/phui/phui-button.css',
3773
+
'uri' => '/res/3b21ca84/rsrc/css/phui/phui-button.css',
3774
3774
'type' => 'css',
3775
3775
'requires' =>
3776
3776
array(
···
4257
4257
), array(
4258
4258
'packages' =>
4259
4259
array(
4260
-
'b2f506ea' =>
4260
+
'0ed58ed4' =>
4261
4261
array(
4262
4262
'name' => 'core.pkg.css',
4263
4263
'symbols' =>
···
4306
4306
41 => 'phabricator-tag-view-css',
4307
4307
42 => 'phui-list-view-css',
4308
4308
),
4309
-
'uri' => '/res/pkg/b2f506ea/core.pkg.css',
4309
+
'uri' => '/res/pkg/0ed58ed4/core.pkg.css',
4310
4310
'type' => 'css',
4311
4311
),
4312
-
'3a57ca2f' =>
4312
+
'9eabd244' =>
4313
4313
array(
4314
4314
'name' => 'core.pkg.js',
4315
4315
'symbols' =>
···
4354
4354
37 => 'javelin-color',
4355
4355
38 => 'javelin-fx',
4356
4356
),
4357
-
'uri' => '/res/pkg/3a57ca2f/core.pkg.js',
4357
+
'uri' => '/res/pkg/9eabd244/core.pkg.js',
4358
4358
'type' => 'js',
4359
4359
),
4360
4360
'4ccfeb47' =>
···
4498
4498
),
4499
4499
'reverse' =>
4500
4500
array(
4501
-
'aphront-dialog-view-css' => 'b2f506ea',
4502
-
'aphront-error-view-css' => 'b2f506ea',
4503
-
'aphront-list-filter-view-css' => 'b2f506ea',
4504
-
'aphront-pager-view-css' => 'b2f506ea',
4505
-
'aphront-panel-view-css' => 'b2f506ea',
4506
-
'aphront-table-view-css' => 'b2f506ea',
4507
-
'aphront-tokenizer-control-css' => 'b2f506ea',
4508
-
'aphront-tooltip-css' => 'b2f506ea',
4509
-
'aphront-typeahead-control-css' => 'b2f506ea',
4501
+
'aphront-dialog-view-css' => '0ed58ed4',
4502
+
'aphront-error-view-css' => '0ed58ed4',
4503
+
'aphront-list-filter-view-css' => '0ed58ed4',
4504
+
'aphront-pager-view-css' => '0ed58ed4',
4505
+
'aphront-panel-view-css' => '0ed58ed4',
4506
+
'aphront-table-view-css' => '0ed58ed4',
4507
+
'aphront-tokenizer-control-css' => '0ed58ed4',
4508
+
'aphront-tooltip-css' => '0ed58ed4',
4509
+
'aphront-typeahead-control-css' => '0ed58ed4',
4510
4510
'differential-changeset-view-css' => '4dc2311c',
4511
4511
'differential-core-view-css' => '4dc2311c',
4512
4512
'differential-inline-comment-editor' => '5e9e5c4e',
···
4520
4520
'differential-table-of-contents-css' => '4dc2311c',
4521
4521
'diffusion-commit-view-css' => 'c8ce2d88',
4522
4522
'diffusion-icons-css' => 'c8ce2d88',
4523
-
'global-drag-and-drop-css' => 'b2f506ea',
4523
+
'global-drag-and-drop-css' => '0ed58ed4',
4524
4524
'inline-comment-summary-css' => '4dc2311c',
4525
-
'javelin-aphlict' => '3a57ca2f',
4525
+
'javelin-aphlict' => '9eabd244',
4526
4526
'javelin-behavior' => '9564fa17',
4527
-
'javelin-behavior-aphlict-dropdown' => '3a57ca2f',
4528
-
'javelin-behavior-aphlict-listen' => '3a57ca2f',
4529
-
'javelin-behavior-aphront-basic-tokenizer' => '3a57ca2f',
4527
+
'javelin-behavior-aphlict-dropdown' => '9eabd244',
4528
+
'javelin-behavior-aphlict-listen' => '9eabd244',
4529
+
'javelin-behavior-aphront-basic-tokenizer' => '9eabd244',
4530
4530
'javelin-behavior-aphront-drag-and-drop-textarea' => '5e9e5c4e',
4531
-
'javelin-behavior-aphront-form-disable-on-submit' => '3a57ca2f',
4531
+
'javelin-behavior-aphront-form-disable-on-submit' => '9eabd244',
4532
4532
'javelin-behavior-audit-preview' => '96909266',
4533
4533
'javelin-behavior-dark-console' => '4ccfeb47',
4534
-
'javelin-behavior-device' => '3a57ca2f',
4534
+
'javelin-behavior-device' => '9eabd244',
4535
4535
'javelin-behavior-differential-accept-with-errors' => '5e9e5c4e',
4536
4536
'javelin-behavior-differential-add-reviewers-and-ccs' => '5e9e5c4e',
4537
4537
'javelin-behavior-differential-comment-jump' => '5e9e5c4e',
···
4547
4547
'javelin-behavior-diffusion-commit-graph' => '96909266',
4548
4548
'javelin-behavior-diffusion-pull-lastmodified' => '96909266',
4549
4549
'javelin-behavior-error-log' => '4ccfeb47',
4550
-
'javelin-behavior-global-drag-and-drop' => '3a57ca2f',
4551
-
'javelin-behavior-history-install' => '3a57ca2f',
4552
-
'javelin-behavior-konami' => '3a57ca2f',
4553
-
'javelin-behavior-lightbox-attachments' => '3a57ca2f',
4550
+
'javelin-behavior-global-drag-and-drop' => '9eabd244',
4551
+
'javelin-behavior-history-install' => '9eabd244',
4552
+
'javelin-behavior-konami' => '9eabd244',
4553
+
'javelin-behavior-lightbox-attachments' => '9eabd244',
4554
4554
'javelin-behavior-load-blame' => '5e9e5c4e',
4555
4555
'javelin-behavior-maniphest-batch-selector' => '0a694954',
4556
4556
'javelin-behavior-maniphest-subpriority-editor' => '0a694954',
4557
4557
'javelin-behavior-maniphest-transaction-controls' => '0a694954',
4558
4558
'javelin-behavior-maniphest-transaction-expand' => '0a694954',
4559
4559
'javelin-behavior-maniphest-transaction-preview' => '0a694954',
4560
-
'javelin-behavior-phabricator-active-nav' => '3a57ca2f',
4561
-
'javelin-behavior-phabricator-autofocus' => '3a57ca2f',
4562
-
'javelin-behavior-phabricator-gesture' => '3a57ca2f',
4563
-
'javelin-behavior-phabricator-hovercards' => '3a57ca2f',
4564
-
'javelin-behavior-phabricator-keyboard-shortcuts' => '3a57ca2f',
4565
-
'javelin-behavior-phabricator-nav' => '3a57ca2f',
4560
+
'javelin-behavior-phabricator-active-nav' => '9eabd244',
4561
+
'javelin-behavior-phabricator-autofocus' => '9eabd244',
4562
+
'javelin-behavior-phabricator-gesture' => '9eabd244',
4563
+
'javelin-behavior-phabricator-hovercards' => '9eabd244',
4564
+
'javelin-behavior-phabricator-keyboard-shortcuts' => '9eabd244',
4565
+
'javelin-behavior-phabricator-nav' => '9eabd244',
4566
4566
'javelin-behavior-phabricator-object-selector' => '5e9e5c4e',
4567
-
'javelin-behavior-phabricator-oncopy' => '3a57ca2f',
4568
-
'javelin-behavior-phabricator-remarkup-assist' => '3a57ca2f',
4569
-
'javelin-behavior-phabricator-reveal-content' => '3a57ca2f',
4570
-
'javelin-behavior-phabricator-search-typeahead' => '3a57ca2f',
4571
-
'javelin-behavior-phabricator-tooltips' => '3a57ca2f',
4572
-
'javelin-behavior-phabricator-watch-anchor' => '3a57ca2f',
4573
-
'javelin-behavior-refresh-csrf' => '3a57ca2f',
4567
+
'javelin-behavior-phabricator-oncopy' => '9eabd244',
4568
+
'javelin-behavior-phabricator-remarkup-assist' => '9eabd244',
4569
+
'javelin-behavior-phabricator-reveal-content' => '9eabd244',
4570
+
'javelin-behavior-phabricator-search-typeahead' => '9eabd244',
4571
+
'javelin-behavior-phabricator-tooltips' => '9eabd244',
4572
+
'javelin-behavior-phabricator-watch-anchor' => '9eabd244',
4573
+
'javelin-behavior-refresh-csrf' => '9eabd244',
4574
4574
'javelin-behavior-repository-crossreference' => '5e9e5c4e',
4575
-
'javelin-behavior-toggle-class' => '3a57ca2f',
4576
-
'javelin-behavior-workflow' => '3a57ca2f',
4577
-
'javelin-color' => '3a57ca2f',
4575
+
'javelin-behavior-toggle-class' => '9eabd244',
4576
+
'javelin-behavior-workflow' => '9eabd244',
4577
+
'javelin-color' => '9eabd244',
4578
4578
'javelin-dom' => '9564fa17',
4579
4579
'javelin-event' => '9564fa17',
4580
-
'javelin-fx' => '3a57ca2f',
4580
+
'javelin-fx' => '9eabd244',
4581
4581
'javelin-history' => '9564fa17',
4582
4582
'javelin-install' => '9564fa17',
4583
4583
'javelin-json' => '9564fa17',
···
4595
4595
'javelin-util' => '9564fa17',
4596
4596
'javelin-vector' => '9564fa17',
4597
4597
'javelin-workflow' => '9564fa17',
4598
-
'lightbox-attachment-css' => 'b2f506ea',
4598
+
'lightbox-attachment-css' => '0ed58ed4',
4599
4599
'maniphest-task-summary-css' => '49898640',
4600
-
'phabricator-action-list-view-css' => 'b2f506ea',
4601
-
'phabricator-application-launch-view-css' => 'b2f506ea',
4602
-
'phabricator-busy' => '3a57ca2f',
4600
+
'phabricator-action-list-view-css' => '0ed58ed4',
4601
+
'phabricator-application-launch-view-css' => '0ed58ed4',
4602
+
'phabricator-busy' => '9eabd244',
4603
4603
'phabricator-content-source-view-css' => '4dc2311c',
4604
-
'phabricator-core-css' => 'b2f506ea',
4605
-
'phabricator-crumbs-view-css' => 'b2f506ea',
4604
+
'phabricator-core-css' => '0ed58ed4',
4605
+
'phabricator-crumbs-view-css' => '0ed58ed4',
4606
4606
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
4607
-
'phabricator-dropdown-menu' => '3a57ca2f',
4608
-
'phabricator-file-upload' => '3a57ca2f',
4609
-
'phabricator-filetree-view-css' => 'b2f506ea',
4610
-
'phabricator-flag-css' => 'b2f506ea',
4611
-
'phabricator-hovercard' => '3a57ca2f',
4612
-
'phabricator-jump-nav' => 'b2f506ea',
4613
-
'phabricator-keyboard-shortcut' => '3a57ca2f',
4614
-
'phabricator-keyboard-shortcut-manager' => '3a57ca2f',
4615
-
'phabricator-main-menu-view' => 'b2f506ea',
4616
-
'phabricator-menu-item' => '3a57ca2f',
4617
-
'phabricator-nav-view-css' => 'b2f506ea',
4618
-
'phabricator-notification' => '3a57ca2f',
4619
-
'phabricator-notification-css' => 'b2f506ea',
4620
-
'phabricator-notification-menu-css' => 'b2f506ea',
4607
+
'phabricator-dropdown-menu' => '9eabd244',
4608
+
'phabricator-file-upload' => '9eabd244',
4609
+
'phabricator-filetree-view-css' => '0ed58ed4',
4610
+
'phabricator-flag-css' => '0ed58ed4',
4611
+
'phabricator-hovercard' => '9eabd244',
4612
+
'phabricator-jump-nav' => '0ed58ed4',
4613
+
'phabricator-keyboard-shortcut' => '9eabd244',
4614
+
'phabricator-keyboard-shortcut-manager' => '9eabd244',
4615
+
'phabricator-main-menu-view' => '0ed58ed4',
4616
+
'phabricator-menu-item' => '9eabd244',
4617
+
'phabricator-nav-view-css' => '0ed58ed4',
4618
+
'phabricator-notification' => '9eabd244',
4619
+
'phabricator-notification-css' => '0ed58ed4',
4620
+
'phabricator-notification-menu-css' => '0ed58ed4',
4621
4621
'phabricator-object-selector-css' => '4dc2311c',
4622
-
'phabricator-phtize' => '3a57ca2f',
4623
-
'phabricator-prefab' => '3a57ca2f',
4622
+
'phabricator-phtize' => '9eabd244',
4623
+
'phabricator-prefab' => '9eabd244',
4624
4624
'phabricator-project-tag-css' => '49898640',
4625
-
'phabricator-remarkup-css' => 'b2f506ea',
4625
+
'phabricator-remarkup-css' => '0ed58ed4',
4626
4626
'phabricator-shaped-request' => '5e9e5c4e',
4627
-
'phabricator-side-menu-view-css' => 'b2f506ea',
4628
-
'phabricator-standard-page-view' => 'b2f506ea',
4629
-
'phabricator-tag-view-css' => 'b2f506ea',
4630
-
'phabricator-textareautils' => '3a57ca2f',
4631
-
'phabricator-tooltip' => '3a57ca2f',
4632
-
'phabricator-transaction-view-css' => 'b2f506ea',
4633
-
'phabricator-zindex-css' => 'b2f506ea',
4634
-
'phui-button-css' => 'b2f506ea',
4635
-
'phui-form-css' => 'b2f506ea',
4636
-
'phui-form-view-css' => 'b2f506ea',
4637
-
'phui-header-view-css' => 'b2f506ea',
4638
-
'phui-icon-view-css' => 'b2f506ea',
4639
-
'phui-list-view-css' => 'b2f506ea',
4640
-
'phui-object-item-list-view-css' => 'b2f506ea',
4641
-
'phui-property-list-view-css' => 'b2f506ea',
4642
-
'phui-spacing-css' => 'b2f506ea',
4643
-
'sprite-apps-large-css' => 'b2f506ea',
4644
-
'sprite-gradient-css' => 'b2f506ea',
4645
-
'sprite-icons-css' => 'b2f506ea',
4646
-
'sprite-menu-css' => 'b2f506ea',
4647
-
'sprite-status-css' => 'b2f506ea',
4648
-
'syntax-highlighting-css' => 'b2f506ea',
4627
+
'phabricator-side-menu-view-css' => '0ed58ed4',
4628
+
'phabricator-standard-page-view' => '0ed58ed4',
4629
+
'phabricator-tag-view-css' => '0ed58ed4',
4630
+
'phabricator-textareautils' => '9eabd244',
4631
+
'phabricator-tooltip' => '9eabd244',
4632
+
'phabricator-transaction-view-css' => '0ed58ed4',
4633
+
'phabricator-zindex-css' => '0ed58ed4',
4634
+
'phui-button-css' => '0ed58ed4',
4635
+
'phui-form-css' => '0ed58ed4',
4636
+
'phui-form-view-css' => '0ed58ed4',
4637
+
'phui-header-view-css' => '0ed58ed4',
4638
+
'phui-icon-view-css' => '0ed58ed4',
4639
+
'phui-list-view-css' => '0ed58ed4',
4640
+
'phui-object-item-list-view-css' => '0ed58ed4',
4641
+
'phui-property-list-view-css' => '0ed58ed4',
4642
+
'phui-spacing-css' => '0ed58ed4',
4643
+
'sprite-apps-large-css' => '0ed58ed4',
4644
+
'sprite-gradient-css' => '0ed58ed4',
4645
+
'sprite-icons-css' => '0ed58ed4',
4646
+
'sprite-menu-css' => '0ed58ed4',
4647
+
'sprite-status-css' => '0ed58ed4',
4648
+
'syntax-highlighting-css' => '0ed58ed4',
4649
4649
),
4650
4650
));
+12
-1
webroot/rsrc/js/core/DropdownMenuItem.js
+12
-1
webroot/rsrc/js/core/DropdownMenuItem.js
···
17
17
_action : null,
18
18
19
19
render : function() {
20
+
var classes = [];
21
+
classes.push('dropdown-menu-item');
22
+
23
+
if (this.getSelected()) {
24
+
classes.push('dropdown-menu-item-selected');
25
+
}
26
+
27
+
if (this.getDisabled()) {
28
+
classes.push('dropdown-menu-item-disabled');
29
+
}
30
+
20
31
var attrs = {
21
32
href: this.getHref(),
22
33
meta: { item: this },
23
-
className: this.getSelected() ? 'phabricator-menu-item-selected' : null
34
+
className: classes.join(' ')
24
35
};
25
36
26
37
if (this.getDisabled()) {