recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Stop writing empty strings to the ownerPHID column

Summary: If we're unassigning an owner from a task it should set the column to `NULL` rather than an empty string. Fixes T3239

Test Plan: Assigned and Unassigned a task. Make sure the db is doing as excpected. Ran the patch, checked the db.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3239

Differential Revision: https://secure.phabricator.com/D6017

authored by

Gareth Evans and committed by
epriestley 183bb8c8 689c6f2f

+6 -1
+1
resources/sql/patches/20130523.maniphest_owners.sql
··· 1 + update {$NAMESPACE}_maniphest.maniphest_task set ownerPHID = NULL WHERE ownerPHID = '';
+1 -1
src/applications/maniphest/storage/ManiphestTask.php
··· 90 90 } 91 91 92 92 public function setOwnerPHID($phid) { 93 - $this->ownerPHID = $phid; 93 + $this->ownerPHID = nonempty($phid, null); 94 94 $this->subscribersNeedUpdate = true; 95 95 return $this; 96 96 }
+4
src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php
··· 1310 1310 'type' => 'sql', 1311 1311 'name' => $this->getPatchPath('20130521.dropconphimages.sql'), 1312 1312 ), 1313 + '20130523.maniphest_owners.sql' => array( 1314 + 'type' => 'sql', 1315 + 'name' => $this->getPatchPath('20130523.maniphest_owners.sql'), 1316 + ), 1313 1317 1314 1318 ); 1315 1319 }