@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Update parent/child revision timeline messages to use modern language ("parent revision")

Summary:
See PHI746. See also T11833, perhaps. Ref T13151.

Long ago, parent revisions were called "dependent revisions". This was changed to "parent revisions" in the action UI to improve clarity, but not changed in the timeline stories.

Update the timeline stories to use the same language the actions in the UI use.

Test Plan:
{F5732876}

{F5732877}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19514

+50 -40
+6 -6
src/applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php
··· 33 33 $add_edges) { 34 34 35 35 return pht( 36 - '%s added %s dependent revision(s): %s.', 36 + '%s added %s child revision(s): %s.', 37 37 $actor, 38 38 $add_count, 39 39 $add_edges); ··· 45 45 $rem_edges) { 46 46 47 47 return pht( 48 - '%s removed %s dependent revision(s): %s.', 48 + '%s removed %s child revision(s): %s.', 49 49 $actor, 50 50 $rem_count, 51 51 $rem_edges); ··· 60 60 $rem_edges) { 61 61 62 62 return pht( 63 - '%s edited dependent revision(s), added %s: %s; removed %s: %s.', 63 + '%s edited child revision(s), added %s: %s; removed %s: %s.', 64 64 $actor, 65 65 $add_count, 66 66 $add_edges, ··· 75 75 $add_edges) { 76 76 77 77 return pht( 78 - '%s added %s dependent revision(s) for %s: %s.', 78 + '%s added %s child revision(s) for %s: %s.', 79 79 $actor, 80 80 $add_count, 81 81 $object, ··· 89 89 $rem_edges) { 90 90 91 91 return pht( 92 - '%s removed %s dependent revision(s) for %s: %s.', 92 + '%s removed %s child revision(s) for %s: %s.', 93 93 $actor, 94 94 $rem_count, 95 95 $object, ··· 106 106 $rem_edges) { 107 107 108 108 return pht( 109 - '%s edited dependent revision(s) for %s, added %s: %s; removed %s: %s.', 109 + '%s edited child revision(s) for %s, added %s: %s; removed %s: %s.', 110 110 $actor, 111 111 $object, 112 112 $add_count,
+6 -6
src/applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php
··· 36 36 $add_edges) { 37 37 38 38 return pht( 39 - '%s added %s dependencie(s): %s.', 39 + '%s added %s parent revision(s): %s.', 40 40 $actor, 41 41 $add_count, 42 42 $add_edges); ··· 48 48 $rem_edges) { 49 49 50 50 return pht( 51 - '%s removed %s dependencie(s): %s.', 51 + '%s removed %s parent revision(s): %s.', 52 52 $actor, 53 53 $rem_count, 54 54 $rem_edges); ··· 63 63 $rem_edges) { 64 64 65 65 return pht( 66 - '%s edited dependencie(s), added %s: %s; removed %s: %s.', 66 + '%s edited parent revision(s), added %s: %s; removed %s: %s.', 67 67 $actor, 68 68 $add_count, 69 69 $add_edges, ··· 78 78 $add_edges) { 79 79 80 80 return pht( 81 - '%s added %s dependencie(s) for %s: %s.', 81 + '%s added %s parent revision(s) for %s: %s.', 82 82 $actor, 83 83 $add_count, 84 84 $object, ··· 92 92 $rem_edges) { 93 93 94 94 return pht( 95 - '%s removed %s dependencie(s) for %s: %s.', 95 + '%s removed %s parent revision(s) for %s: %s.', 96 96 $actor, 97 97 $rem_count, 98 98 $object, ··· 109 109 $rem_edges) { 110 110 111 111 return pht( 112 - '%s edited dependencie(s) for %s, added %s: %s; removed %s: %s.', 112 + '%s edited parent revision(s) for %s, added %s: %s; removed %s: %s.', 113 113 $actor, 114 114 $object, 115 115 $add_count,
+38 -28
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
··· 595 595 '%s changed files, attached: %3$s; detached: %5$s.', 596 596 597 597 598 - '%s added %s dependencie(s): %s.' => array( 598 + '%s added %s parent revision(s): %s.' => array( 599 599 array( 600 - '%s added a dependency: %3$s.', 601 - '%s added dependencies: %3$s.', 600 + '%s added a parent revision: %3$s.', 601 + '%s added parent revisions: %3$s.', 602 602 ), 603 603 ), 604 604 605 - '%s added %s dependencie(s) for %s: %s.' => array( 605 + '%s added %s parent revision(s) for %s: %s.' => array( 606 606 array( 607 - '%s added a dependency for %3$s: %4$s.', 608 - '%s added dependencies for %3$s: %4$s.', 607 + '%s added a parent revision for %3$s: %4$s.', 608 + '%s added parent revisions for %3$s: %4$s.', 609 609 ), 610 610 ), 611 611 612 - '%s removed %s dependencie(s): %s.' => array( 612 + '%s removed %s parent revision(s): %s.' => array( 613 613 array( 614 - '%s removed a dependency: %3$s.', 615 - '%s removed dependencies: %3$s.', 614 + '%s removed a parent revision: %3$s.', 615 + '%s removed parent revisions: %3$s.', 616 616 ), 617 617 ), 618 618 619 - '%s removed %s dependencie(s) for %s: %s.' => array( 619 + '%s removed %s parent revision(s) for %s: %s.' => array( 620 620 array( 621 - '%s removed a dependency for %3$s: %4$s.', 622 - '%s removed dependencies for %3$s: %4$s.', 621 + '%s removed a parent revision for %3$s: %4$s.', 622 + '%s removed parent revisions for %3$s: %4$s.', 623 623 ), 624 624 ), 625 625 626 - '%s edited dependencie(s), added %s: %s; removed %s: %s.' => array( 627 - '%s edited dependencies, added: %3$s; removed: %5$s.', 626 + '%s edited parent revision(s), added %s: %s; removed %s: %s.' => array( 627 + '%s edited parent revisions, added: %3$s; removed: %5$s.', 628 628 ), 629 629 630 - '%s edited dependencie(s) for %s, added %s: %s; removed %s: %s.' => array( 631 - '%s edited dependencies for %s, added: %3$s; removed: %5$s.', 630 + '%s edited parent revision(s) for %s, '. 631 + 'added %s: %s; removed %s: %s.' => array( 632 + '%s edited parent revisions for %s, added: %3$s; removed: %5$s.', 632 633 ), 633 634 634 - '%s added %s dependent revision(s): %s.' => array( 635 + '%s added %s child revision(s): %s.' => array( 635 636 array( 636 - '%s added a dependent revision: %3$s.', 637 - '%s added dependent revisions: %3$s.', 637 + '%s added a child revision: %3$s.', 638 + '%s added child revisions: %3$s.', 638 639 ), 639 640 ), 640 641 641 - '%s added %s dependent revision(s) for %s: %s.' => array( 642 + '%s added %s child revision(s) for %s: %s.' => array( 642 643 array( 643 - '%s added a dependent revision for %3$s: %4$s.', 644 - '%s added dependent revisions for %3$s: %4$s.', 644 + '%s added a child revision for %3$s: %4$s.', 645 + '%s added child revisions for %3$s: %4$s.', 645 646 ), 646 647 ), 647 648 648 - '%s removed %s dependent revision(s): %s.' => array( 649 + '%s removed %s child revision(s): %s.' => array( 649 650 array( 650 - '%s removed a dependent revision: %3$s.', 651 - '%s removed dependent revisions: %3$s.', 651 + '%s removed a child revision: %3$s.', 652 + '%s removed child revisions: %3$s.', 652 653 ), 653 654 ), 654 655 655 - '%s removed %s dependent revision(s) for %s: %s.' => array( 656 + '%s removed %s child revision(s) for %s: %s.' => array( 656 657 array( 657 - '%s removed a dependent revision for %3$s: %4$s.', 658 - '%s removed dependent revisions for %3$s: %4$s.', 658 + '%s removed a child revision for %3$s: %4$s.', 659 + '%s removed child revisions for %3$s: %4$s.', 659 660 ), 661 + ), 662 + 663 + '%s edited child revision(s), added %s: %s; removed %s: %s.' => array( 664 + '%s edited child revisions, added: %3$s; removed: %5$s.', 665 + ), 666 + 667 + '%s edited child revision(s) for %s, '. 668 + 'added %s: %s; removed %s: %s.' => array( 669 + '%s edited child revisions for %s, added: %3$s; removed: %5$s.', 660 670 ), 661 671 662 672 '%s added %s commit(s): %s.' => array(