@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"

Summary: See PHI871. Ref T13197. These sections are only divided visually and don't have textual headers. Add aural headers.

Test Plan: {F5875471}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13197

Differential Revision: https://secure.phabricator.com/D19654

+36 -12
+11 -11
resources/celerity/map.php
··· 423 423 'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072', 424 424 'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08', 425 425 'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f', 426 - 'rsrc/js/application/transactions/behavior-comment-actions.js' => '54110499', 426 + 'rsrc/js/application/transactions/behavior-comment-actions.js' => '038bf27f', 427 427 'rsrc/js/application/transactions/behavior-reorder-configs.js' => 'd7a74243', 428 428 'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96', 429 429 'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '8f29b364', ··· 575 575 'javelin-behavior-bulk-job-reload' => 'edf8a145', 576 576 'javelin-behavior-calendar-month-view' => 'fe33e256', 577 577 'javelin-behavior-choose-control' => '327a00d1', 578 - 'javelin-behavior-comment-actions' => '54110499', 578 + 'javelin-behavior-comment-actions' => '038bf27f', 579 579 'javelin-behavior-config-reorder-fields' => 'b6993408', 580 580 'javelin-behavior-conpherence-menu' => '4047cd35', 581 581 'javelin-behavior-conpherence-participant-pane' => 'd057e45a', ··· 905 905 'javelin-behavior', 906 906 'javelin-uri', 907 907 ), 908 + '038bf27f' => array( 909 + 'javelin-behavior', 910 + 'javelin-stratcom', 911 + 'javelin-workflow', 912 + 'javelin-dom', 913 + 'phuix-form-control-view', 914 + 'phuix-icon-view', 915 + 'javelin-behavior-phabricator-gesture', 916 + ), 908 917 '040fce04' => array( 909 918 'javelin-behavior', 910 919 'javelin-request', ··· 1250 1259 'javelin-stratcom', 1251 1260 'javelin-vector', 1252 1261 'javelin-typeahead-static-source', 1253 - ), 1254 - 54110499 => array( 1255 - 'javelin-behavior', 1256 - 'javelin-stratcom', 1257 - 'javelin-workflow', 1258 - 'javelin-dom', 1259 - 'phuix-form-control-view', 1260 - 'phuix-icon-view', 1261 - 'javelin-behavior-phabricator-gesture', 1262 1262 ), 1263 1263 '549459b8' => array( 1264 1264 'javelin-behavior',
+8
src/applications/transactions/response/PhabricatorApplicationTransactionResponse.php
··· 83 83 $xactions[$key] = hsprintf('%s', $xaction); 84 84 } 85 85 86 + $aural = phutil_tag( 87 + 'h3', 88 + array( 89 + 'class' => 'aural-only', 90 + ), 91 + pht('Comment Preview')); 92 + 86 93 $content = array( 94 + 'header' => hsprintf('%s', $aural), 87 95 'xactions' => $xactions, 88 96 'spacer' => PHUITimelineView::renderSpacer(), 89 97 'previewContent' => hsprintf('%s', $this->getPreviewContent()),
+7
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 245 245 ->setFlush(true) 246 246 ->addClass('phui-comment-form-view') 247 247 ->addSigil('phui-comment-form') 248 + ->appendChild( 249 + phutil_tag( 250 + 'h3', 251 + array( 252 + 'class' => 'aural-only', 253 + ), 254 + pht('Add Comment'))) 248 255 ->appendChild($image) 249 256 ->appendChild($badge_view) 250 257 ->appendChild($wedge)
+9 -1
src/view/phui/PHUITimelineView.php
··· 83 83 'class' => 'phui-timeline-view', 84 84 'id' => $this->id, 85 85 ), 86 - $events); 86 + array( 87 + phutil_tag( 88 + 'h3', 89 + array( 90 + 'class' => 'aural-only', 91 + ), 92 + pht('Event Timeline')), 93 + $events, 94 + )); 87 95 } 88 96 89 97 public function buildEvents() {
+1
webroot/rsrc/js/application/transactions/behavior-comment-actions.js
··· 105 105 JX.DOM.setContent( 106 106 preview_root, 107 107 [ 108 + JX.$H(response.header), 108 109 JX.$H(response.xactions.join('')), 109 110 JX.$H(response.previewContent) 110 111 ]);