@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix strlen(null) PHP 8.1 error when pushing into a fresh repository
Summary:
Doing a git push into a fresh repository over https fails with a PHP 8.1 strlen(null) error.
This fixes it.
Fixes T15569
Test Plan:
* Create an empty repository on a PHP 8.1 Phorge instance
* Clone it
* Add some data
* git push
Reviewers: O1 Blessed Committers, speck
Reviewed By: O1 Blessed Committers, speck
Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15569
Differential Revision: https://we.phorge.it/D25361
+1
-1
+1
-1
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
+1
-1
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
···
1133
1133
->setHookWait(phutil_microseconds_since($hook_start));
1134
1134
1135
1135
$identifier = $this->getRequestIdentifier();
1136
-
if (strlen($identifier)) {
1136
+
if ($identifier !== null && strlen($identifier)) {
1137
1137
$event->setRequestIdentifier($identifier);
1138
1138
}
1139
1139