recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Transactions - move TYPE_SUBSCRIBERS to require optional implementation

Summary: Ref T6403. This one was pretty easy since no one does anything custom with subscribers.

Test Plan: subscribed / unscribed to a random commit ("audit"). joined / left, watched / unwatched a project

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6403

Differential Revision: https://secure.phabricator.com/D12930

Bob Trahan 18e0ee07 16c8d44c

+2 -14
-2
src/applications/audit/editor/PhabricatorAuditEditor.php
··· 116 116 117 117 switch ($xaction->getTransactionType()) { 118 118 case PhabricatorTransactions::TYPE_COMMENT: 119 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 120 119 case PhabricatorAuditActionConstants::ACTION: 121 120 case PhabricatorAuditActionConstants::INLINE: 122 121 case PhabricatorAuditActionConstants::ADD_AUDITORS: ··· 133 132 134 133 switch ($xaction->getTransactionType()) { 135 134 case PhabricatorTransactions::TYPE_COMMENT: 136 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 137 135 case PhabricatorAuditActionConstants::ACTION: 138 136 case PhabricatorAuditTransaction::TYPE_COMMIT: 139 137 return;
-2
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
··· 111 111 case PhabricatorTransactions::TYPE_COMMENT: 112 112 case PhabricatorTransactions::TYPE_VIEW_POLICY: 113 113 case PhabricatorTransactions::TYPE_EDIT_POLICY: 114 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 115 114 return; 116 115 } 117 116 ··· 153 152 case PhabricatorTransactions::TYPE_COMMENT: 154 153 case PhabricatorTransactions::TYPE_VIEW_POLICY: 155 154 case PhabricatorTransactions::TYPE_EDIT_POLICY: 156 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 157 155 return; 158 156 } 159 157
-2
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 195 195 case PhabricatorTransactions::TYPE_EDIT_POLICY: 196 196 $object->setEditPolicy($xaction->getNewValue()); 197 197 return; 198 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 199 198 case PhabricatorTransactions::TYPE_COMMENT: 200 199 case DifferentialTransaction::TYPE_INLINE: 201 200 return; ··· 578 577 case PhabricatorTransactions::TYPE_VIEW_POLICY: 579 578 case PhabricatorTransactions::TYPE_EDIT_POLICY: 580 579 return; 581 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 582 580 case PhabricatorTransactions::TYPE_COMMENT: 583 581 case DifferentialTransaction::TYPE_ACTION: 584 582 return;
-2
src/applications/fund/editor/FundInitiativeEditor.php
··· 102 102 103 103 $object->setTotalAsCurrency($total); 104 104 return; 105 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 106 105 case PhabricatorTransactions::TYPE_VIEW_POLICY: 107 106 case PhabricatorTransactions::TYPE_EDIT_POLICY: 108 107 return; ··· 155 154 156 155 $editor->applyTransactions($backer, $subx); 157 156 return; 158 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 159 157 case PhabricatorTransactions::TYPE_VIEW_POLICY: 160 158 case PhabricatorTransactions::TYPE_EDIT_POLICY: 161 159 return;
-2
src/applications/paste/editor/PhabricatorPasteEditor.php
··· 89 89 $object->setEditPolicy($xaction->getNewValue()); 90 90 return; 91 91 case PhabricatorTransactions::TYPE_COMMENT: 92 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 93 92 return; 94 93 } 95 94 ··· 107 106 case PhabricatorTransactions::TYPE_VIEW_POLICY: 108 107 case PhabricatorTransactions::TYPE_EDIT_POLICY: 109 108 case PhabricatorTransactions::TYPE_COMMENT: 110 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 111 109 return; 112 110 } 113 111
-3
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
··· 102 102 case PhabricatorProjectTransaction::TYPE_LOCKED: 103 103 $object->setIsMembershipLocked($xaction->getNewValue()); 104 104 return; 105 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 106 - return; 107 105 case PhabricatorTransactions::TYPE_VIEW_POLICY: 108 106 $object->setViewPolicy($xaction->getNewValue()); 109 107 return; ··· 159 157 } 160 158 161 159 return; 162 - case PhabricatorTransactions::TYPE_SUBSCRIBERS: 163 160 case PhabricatorTransactions::TYPE_VIEW_POLICY: 164 161 case PhabricatorTransactions::TYPE_EDIT_POLICY: 165 162 case PhabricatorTransactions::TYPE_JOIN_POLICY:
+2 -1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 401 401 case PhabricatorTransactions::TYPE_CUSTOMFIELD: 402 402 $field = $this->getCustomFieldForTransaction($object, $xaction); 403 403 return $field->applyApplicationTransactionInternalEffects($xaction); 404 + case PhabricatorTransactions::TYPE_SUBSCRIBERS: 404 405 case PhabricatorTransactions::TYPE_INLINESTATE: 405 406 case PhabricatorTransactions::TYPE_EDGE: 406 407 return $this->applyBuiltinInternalTransaction($object, $xaction); ··· 441 442 $xaction->getOldValue(), 442 443 $xaction->getNewValue())); 443 444 $this->subscribers = $subscribers; 445 + return $this->applyBuiltinExternalTransaction($object, $xaction); 444 446 445 - break; 446 447 case PhabricatorTransactions::TYPE_EDGE: 447 448 if ($this->getIsInverseEdgeEditor()) { 448 449 // If we're writing an inverse edge transaction, don't actually