@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve color use in "[+++- ]" element for colorblind users
Summary:
Ref T13127. Users with red/green colorblindness may have difficulty using this element in its current incarnation.
We could give it different behavior if the "Accessibility" option is set for red/green colorblind users, but try a one-size-fits-all approach since the red/green aren't wholly clear anwyay.
Test Plan: {F5530050}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13127
Differential Revision: https://secure.phabricator.com/D19385
+22
-10
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e68cf1fa',
11
11
'conpherence.pkg.js' => '15191c65',
12
-
'core.pkg.css' => 'c30f6eaa',
12
+
'core.pkg.css' => 'cb8ae4dc',
13
13
'core.pkg.js' => 'e1f0f7bd',
14
14
'differential.pkg.css' => '06dc617c',
15
15
'differential.pkg.js' => 'c2ca903a',
···
131
131
'rsrc/css/phui/object-item/phui-oi-color.css' => 'cd2b9b77',
132
132
'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => '08f4ccc3',
133
133
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '9d9685d6',
134
-
'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'ae1404ba',
134
+
'rsrc/css/phui/object-item/phui-oi-list-view.css' => '7c5c1291',
135
135
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => 'a8beebea',
136
136
'rsrc/css/phui/phui-action-list.css' => '0bcd9a45',
137
137
'rsrc/css/phui/phui-action-panel.css' => 'b4798122',
···
838
838
'phui-oi-color-css' => 'cd2b9b77',
839
839
'phui-oi-drag-ui-css' => '08f4ccc3',
840
840
'phui-oi-flush-ui-css' => '9d9685d6',
841
-
'phui-oi-list-view-css' => 'ae1404ba',
841
+
'phui-oi-list-view-css' => '7c5c1291',
842
842
'phui-oi-simple-ui-css' => 'a8beebea',
843
843
'phui-pager-css' => 'edcbc226',
844
844
'phui-pinboard-view-css' => '2495140e',
+9
-1
src/applications/differential/view/DifferentialRevisionListView.php
+9
-1
src/applications/differential/view/DifferentialRevisionListView.php
···
229
229
$classes = array();
230
230
$classes[] = 'differential-revision-size';
231
231
232
+
$tip = array();
233
+
$tip[] = pht('%s Lines', new PhutilNumber($n));
234
+
232
235
if ($plus_count <= 1) {
233
236
$classes[] = 'differential-revision-small';
237
+
$tip[] = pht('Smaller Change');
234
238
}
235
239
236
240
if ($plus_count >= 4) {
237
241
$classes[] = 'differential-revision-large';
242
+
$tip[] = pht('Larger Change');
238
243
}
239
244
245
+
$tip = phutil_implode_html(" \xC2\xB7 ", $tip);
246
+
240
247
return javelin_tag(
241
248
'span',
242
249
array(
243
250
'class' => implode(' ', $classes),
244
251
'sigil' => 'has-tooltip',
245
252
'meta' => array(
246
-
'tip' => pht('%s Lines', new PhutilNumber($n)),
253
+
'tip' => $tip,
247
254
'align' => 'E',
255
+
'size' => 400,
248
256
),
249
257
),
250
258
$size);
+10
-6
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+10
-6
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
···
697
697
698
698
.differential-revision-size .phui-icon-view {
699
699
margin: 0 1px 0 1px;
700
-
font-size: smaller;
701
-
color: {$blueborder};
700
+
font-size: 7px;
701
+
position: relative;
702
+
top: -2px;
703
+
color: {$lightbluetext};
702
704
}
703
705
704
706
.differential-revision-large {
705
-
background: {$sh-redbackground};
707
+
background: {$sh-orangebackground};
706
708
}
707
709
710
+
/* NOTE: These are intentionally using nonstandard colors, see T13127. */
711
+
708
712
.differential-revision-large .phui-icon-view {
709
-
color: {$red};
713
+
color: #e5ae7e;
710
714
}
711
715
712
716
.differential-revision-small {
713
-
background: {$sh-greenbackground};
717
+
background: #f2f7ff;
714
718
}
715
719
716
720
.differential-revision-small .phui-icon-view {
717
-
color: {$green};
721
+
color: #6699ba;
718
722
}