recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't show the "Override Lock" prompt when creating objects

Summary:
Fixes T12369. When you create objects they may technically be locked: either because the default state is legitimately locked, or because the default policies prevent you from viewing so we sort of technically end in a locked state.

Regardless, don't prompt during creation, since this prompt isn't useful even if the lock detection is completely legitimate.

Test Plan:
- In {nav Applications > Maniphest > Configure}, set "Default View Policy" to "No One".
- Tried to create a task.
- Before patch: prompted to override lock.
- After patch: no override prompt.

Reviewers: chad

Reviewed By: chad

Subscribers: d.maznekov

Maniphest Tasks: T12369

Differential Revision: https://secure.phabricator.com/D17541

epriestley 1953ab98 aa91dc99

+4
+4
src/applications/transactions/editengine/PhabricatorEditEngine.php
··· 996 996 $config = $this->getEditEngineConfiguration() 997 997 ->attachEngine($this); 998 998 999 + // NOTE: Don't prompt users to override locks when creating objects, 1000 + // even if the default settings would create a locked object. 1001 + 999 1002 $can_interact = PhabricatorPolicyFilter::canInteract($viewer, $object); 1000 1003 if (!$can_interact && 1004 + !$this->getIsCreate() && 1001 1005 !$request->getBool('editEngine') && 1002 1006 !$request->getBool('overrideLock')) { 1003 1007