@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix subtype extension support check
Summary: Fixes T13663. `supportsSubtypes` tries to create an editable object, but this isn't always valid for `PhabricatorCalendarImport`. Use `instanceof` instead.
Test Plan:
- Edited calendar import, tasks (2 different subtypes), and projects (2 different subtypes).
- Changed task subtypes using {nav Change Subtype} action and batch editor.
- Changed task and project subtypes using Conduit.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin
Maniphest Tasks: T13663
Differential Revision: https://secure.phabricator.com/D21714
+1
-1
+1
-1
src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php
+1
-1
src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php
···
21
21
public function supportsObject(
22
22
PhabricatorEditEngine $engine,
23
23
PhabricatorApplicationTransactionInterface $object) {
24
-
return $engine->supportsSubtypes();
24
+
return ($object instanceof PhabricatorEditEngineSubtypeInterface);
25
25
}
26
26
27
27
public function buildCustomEditFields(