@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Give disabled crumb actions a distinct visual style
Summary: Ref T603. When you aren't allowed to take a top-level action (usually "Create Thing"), visually disable the action.
Test Plan: {F69596}
Reviewers: chad
Reviewed By: chad
CC: chad, aran, asherkin
Maniphest Tasks: T603
Differential Revision: https://secure.phabricator.com/D7318
+61
-47
+46
-46
src/__celerity_resource_map__.php
+46
-46
src/__celerity_resource_map__.php
···
3145
3145
),
3146
3146
'phabricator-crumbs-view-css' =>
3147
3147
array(
3148
-
'uri' => '/res/4d722e16/rsrc/css/layout/phabricator-crumbs-view.css',
3148
+
'uri' => '/res/f3c7068b/rsrc/css/layout/phabricator-crumbs-view.css',
3149
3149
'type' => 'css',
3150
3150
'requires' =>
3151
3151
array(
···
4272
4272
), array(
4273
4273
'packages' =>
4274
4274
array(
4275
-
'0ed58ed4' =>
4275
+
'ad23f226' =>
4276
4276
array(
4277
4277
'name' => 'core.pkg.css',
4278
4278
'symbols' =>
···
4321
4321
41 => 'phabricator-tag-view-css',
4322
4322
42 => 'phui-list-view-css',
4323
4323
),
4324
-
'uri' => '/res/pkg/0ed58ed4/core.pkg.css',
4324
+
'uri' => '/res/pkg/ad23f226/core.pkg.css',
4325
4325
'type' => 'css',
4326
4326
),
4327
4327
'adee86d9' =>
···
4513
4513
),
4514
4514
'reverse' =>
4515
4515
array(
4516
-
'aphront-dialog-view-css' => '0ed58ed4',
4517
-
'aphront-error-view-css' => '0ed58ed4',
4518
-
'aphront-list-filter-view-css' => '0ed58ed4',
4519
-
'aphront-pager-view-css' => '0ed58ed4',
4520
-
'aphront-panel-view-css' => '0ed58ed4',
4521
-
'aphront-table-view-css' => '0ed58ed4',
4522
-
'aphront-tokenizer-control-css' => '0ed58ed4',
4523
-
'aphront-tooltip-css' => '0ed58ed4',
4524
-
'aphront-typeahead-control-css' => '0ed58ed4',
4516
+
'aphront-dialog-view-css' => 'ad23f226',
4517
+
'aphront-error-view-css' => 'ad23f226',
4518
+
'aphront-list-filter-view-css' => 'ad23f226',
4519
+
'aphront-pager-view-css' => 'ad23f226',
4520
+
'aphront-panel-view-css' => 'ad23f226',
4521
+
'aphront-table-view-css' => 'ad23f226',
4522
+
'aphront-tokenizer-control-css' => 'ad23f226',
4523
+
'aphront-tooltip-css' => 'ad23f226',
4524
+
'aphront-typeahead-control-css' => 'ad23f226',
4525
4525
'differential-changeset-view-css' => '1b8a291d',
4526
4526
'differential-core-view-css' => '1b8a291d',
4527
4527
'differential-inline-comment-editor' => '5e9e5c4e',
···
4535
4535
'differential-table-of-contents-css' => '1b8a291d',
4536
4536
'diffusion-commit-view-css' => 'c8ce2d88',
4537
4537
'diffusion-icons-css' => 'c8ce2d88',
4538
-
'global-drag-and-drop-css' => '0ed58ed4',
4538
+
'global-drag-and-drop-css' => 'ad23f226',
4539
4539
'inline-comment-summary-css' => '1b8a291d',
4540
4540
'javelin-aphlict' => 'adee86d9',
4541
4541
'javelin-behavior' => '3e3be199',
···
4610
4610
'javelin-util' => '3e3be199',
4611
4611
'javelin-vector' => '3e3be199',
4612
4612
'javelin-workflow' => '3e3be199',
4613
-
'lightbox-attachment-css' => '0ed58ed4',
4613
+
'lightbox-attachment-css' => 'ad23f226',
4614
4614
'maniphest-task-summary-css' => '49898640',
4615
-
'phabricator-action-list-view-css' => '0ed58ed4',
4616
-
'phabricator-application-launch-view-css' => '0ed58ed4',
4615
+
'phabricator-action-list-view-css' => 'ad23f226',
4616
+
'phabricator-application-launch-view-css' => 'ad23f226',
4617
4617
'phabricator-busy' => 'adee86d9',
4618
4618
'phabricator-content-source-view-css' => '1b8a291d',
4619
-
'phabricator-core-css' => '0ed58ed4',
4620
-
'phabricator-crumbs-view-css' => '0ed58ed4',
4619
+
'phabricator-core-css' => 'ad23f226',
4620
+
'phabricator-crumbs-view-css' => 'ad23f226',
4621
4621
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
4622
4622
'phabricator-dropdown-menu' => 'adee86d9',
4623
4623
'phabricator-file-upload' => 'adee86d9',
4624
-
'phabricator-filetree-view-css' => '0ed58ed4',
4625
-
'phabricator-flag-css' => '0ed58ed4',
4624
+
'phabricator-filetree-view-css' => 'ad23f226',
4625
+
'phabricator-flag-css' => 'ad23f226',
4626
4626
'phabricator-hovercard' => 'adee86d9',
4627
-
'phabricator-jump-nav' => '0ed58ed4',
4627
+
'phabricator-jump-nav' => 'ad23f226',
4628
4628
'phabricator-keyboard-shortcut' => 'adee86d9',
4629
4629
'phabricator-keyboard-shortcut-manager' => 'adee86d9',
4630
-
'phabricator-main-menu-view' => '0ed58ed4',
4630
+
'phabricator-main-menu-view' => 'ad23f226',
4631
4631
'phabricator-menu-item' => 'adee86d9',
4632
-
'phabricator-nav-view-css' => '0ed58ed4',
4632
+
'phabricator-nav-view-css' => 'ad23f226',
4633
4633
'phabricator-notification' => 'adee86d9',
4634
-
'phabricator-notification-css' => '0ed58ed4',
4635
-
'phabricator-notification-menu-css' => '0ed58ed4',
4634
+
'phabricator-notification-css' => 'ad23f226',
4635
+
'phabricator-notification-menu-css' => 'ad23f226',
4636
4636
'phabricator-object-selector-css' => '1b8a291d',
4637
4637
'phabricator-phtize' => 'adee86d9',
4638
4638
'phabricator-prefab' => 'adee86d9',
4639
4639
'phabricator-project-tag-css' => '49898640',
4640
-
'phabricator-remarkup-css' => '0ed58ed4',
4640
+
'phabricator-remarkup-css' => 'ad23f226',
4641
4641
'phabricator-shaped-request' => '5e9e5c4e',
4642
-
'phabricator-side-menu-view-css' => '0ed58ed4',
4643
-
'phabricator-standard-page-view' => '0ed58ed4',
4644
-
'phabricator-tag-view-css' => '0ed58ed4',
4642
+
'phabricator-side-menu-view-css' => 'ad23f226',
4643
+
'phabricator-standard-page-view' => 'ad23f226',
4644
+
'phabricator-tag-view-css' => 'ad23f226',
4645
4645
'phabricator-textareautils' => 'adee86d9',
4646
4646
'phabricator-tooltip' => 'adee86d9',
4647
-
'phabricator-transaction-view-css' => '0ed58ed4',
4648
-
'phabricator-zindex-css' => '0ed58ed4',
4649
-
'phui-button-css' => '0ed58ed4',
4650
-
'phui-form-css' => '0ed58ed4',
4651
-
'phui-form-view-css' => '0ed58ed4',
4652
-
'phui-header-view-css' => '0ed58ed4',
4653
-
'phui-icon-view-css' => '0ed58ed4',
4654
-
'phui-list-view-css' => '0ed58ed4',
4655
-
'phui-object-item-list-view-css' => '0ed58ed4',
4656
-
'phui-property-list-view-css' => '0ed58ed4',
4657
-
'phui-spacing-css' => '0ed58ed4',
4658
-
'sprite-apps-large-css' => '0ed58ed4',
4659
-
'sprite-gradient-css' => '0ed58ed4',
4660
-
'sprite-icons-css' => '0ed58ed4',
4661
-
'sprite-menu-css' => '0ed58ed4',
4662
-
'sprite-status-css' => '0ed58ed4',
4663
-
'syntax-highlighting-css' => '0ed58ed4',
4647
+
'phabricator-transaction-view-css' => 'ad23f226',
4648
+
'phabricator-zindex-css' => 'ad23f226',
4649
+
'phui-button-css' => 'ad23f226',
4650
+
'phui-form-css' => 'ad23f226',
4651
+
'phui-form-view-css' => 'ad23f226',
4652
+
'phui-header-view-css' => 'ad23f226',
4653
+
'phui-icon-view-css' => 'ad23f226',
4654
+
'phui-list-view-css' => 'ad23f226',
4655
+
'phui-object-item-list-view-css' => 'ad23f226',
4656
+
'phui-property-list-view-css' => 'ad23f226',
4657
+
'phui-spacing-css' => 'ad23f226',
4658
+
'sprite-apps-large-css' => 'ad23f226',
4659
+
'sprite-gradient-css' => 'ad23f226',
4660
+
'sprite-icons-css' => 'ad23f226',
4661
+
'sprite-menu-css' => 'ad23f226',
4662
+
'sprite-status-css' => 'ad23f226',
4663
+
'syntax-highlighting-css' => 'ad23f226',
4664
4664
),
4665
4665
));
+11
-1
src/view/layout/PhabricatorCrumbsView.php
+11
-1
src/view/layout/PhabricatorCrumbsView.php
···
35
35
foreach ($this->actions as $action) {
36
36
$icon = null;
37
37
if ($action->getIcon()) {
38
+
$icon_name = $action->getIcon();
39
+
if ($action->getDisabled()) {
40
+
$icon_name .= '-grey';
41
+
}
42
+
38
43
$icon = phutil_tag(
39
44
'span',
40
45
array(
41
-
'class' => 'sprite-icons icons-'.$action->getIcon(),
46
+
'class' => 'sprite-icons icons-'.$icon_name,
42
47
),
43
48
'');
44
49
}
···
55
60
}
56
61
$action_classes = $action->getClasses();
57
62
$action_classes[] = 'phabricator-crumbs-action';
63
+
64
+
if ($action->getDisabled()) {
65
+
$action_classes[] = 'phabricator-crumbs-action-disabled';
66
+
}
67
+
58
68
$actions[] = javelin_tag(
59
69
'a',
60
70
array(
+4
webroot/rsrc/css/layout/phabricator-crumbs-view.css
+4
webroot/rsrc/css/layout/phabricator-crumbs-view.css