recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Minor, don't show references in diffusion if there isn't any

Summary:
When there are no other references (and there will be none ususally,
if D2891 is accepted), we would show "References:" with empty contents.

Avoid that by testing for empty output after applying stupid filtering.

Test Plan: Looked in a standard repository with no special refs.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2892

authored by

David Reuss and committed by
epriestley 19d58564 2391c54c

+4
+4
src/applications/diffusion/controller/DiffusionCommitController.php
··· 848 848 $refs = explode(',', $refs); 849 849 $refs = array_map('trim', $refs); 850 850 851 + if (!$refs) { 852 + return null; 853 + } 854 + 851 855 $ref_links = array(); 852 856 foreach ($refs as $ref) { 853 857 $ref_links[] = phutil_render_tag(