@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "HarbormasterBuildCommand"
Summary: Ref T13072. Update the last few constant references to this class and remove it.
Test Plan: Grepped for "HarbormasterBuildCommand", got no hits.
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13072
Differential Revision: https://secure.phabricator.com/D21692
+18
-25
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
1387
1387
'HarbormasterBuildArtifactPHIDType' => 'applications/harbormaster/phid/HarbormasterBuildArtifactPHIDType.php',
1388
1388
'HarbormasterBuildArtifactQuery' => 'applications/harbormaster/query/HarbormasterBuildArtifactQuery.php',
1389
1389
'HarbormasterBuildAutoplan' => 'applications/harbormaster/autoplan/HarbormasterBuildAutoplan.php',
1390
-
'HarbormasterBuildCommand' => 'applications/harbormaster/storage/HarbormasterBuildCommand.php',
1391
1390
'HarbormasterBuildDependencyDatasource' => 'applications/harbormaster/typeahead/HarbormasterBuildDependencyDatasource.php',
1392
1391
'HarbormasterBuildEngine' => 'applications/harbormaster/engine/HarbormasterBuildEngine.php',
1393
1392
'HarbormasterBuildFailureException' => 'applications/harbormaster/exception/HarbormasterBuildFailureException.php',
···
7603
7602
'HarbormasterBuildArtifactPHIDType' => 'PhabricatorPHIDType',
7604
7603
'HarbormasterBuildArtifactQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
7605
7604
'HarbormasterBuildAutoplan' => 'Phobject',
7606
-
'HarbormasterBuildCommand' => 'Phobject',
7607
7605
'HarbormasterBuildDependencyDatasource' => 'PhabricatorTypeaheadDatasource',
7608
7606
'HarbormasterBuildEngine' => 'Phobject',
7609
7607
'HarbormasterBuildFailureException' => 'Exception',
+1
-1
src/applications/harbormaster/step/HarbormasterAbortOlderBuildsBuildStepImplementation.php
+1
-1
src/applications/harbormaster/step/HarbormasterAbortOlderBuildsBuildStepImplementation.php
-11
src/applications/harbormaster/storage/HarbormasterBuildCommand.php
-11
src/applications/harbormaster/storage/HarbormasterBuildCommand.php
+13
-7
src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
+13
-7
src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
···
27
27
$this->renderHandleLink($author_phid));
28
28
case self::TYPE_COMMAND:
29
29
switch ($new) {
30
-
case HarbormasterBuildCommand::COMMAND_RESTART:
30
+
case HarbormasterBuildMessageRestartTransaction::MESSAGETYPE:
31
31
return pht(
32
32
'%s restarted this buildable.',
33
33
$this->renderHandleLink($author_phid));
34
-
case HarbormasterBuildCommand::COMMAND_RESUME:
34
+
case HarbormasterBuildMessageResumeTransaction::MESSAGETYPE:
35
35
return pht(
36
36
'%s resumed this buildable.',
37
37
$this->renderHandleLink($author_phid));
38
-
case HarbormasterBuildCommand::COMMAND_PAUSE:
38
+
case HarbormasterBuildMessagePauseTransaction::MESSAGETYPE:
39
39
return pht(
40
40
'%s paused this buildable.',
41
+
$this->renderHandleLink($author_phid));
42
+
case HarbormasterBuildMessageAbortTransaction::MESSAGETYPE:
43
+
return pht(
44
+
'%s aborted this buildable.',
41
45
$this->renderHandleLink($author_phid));
42
46
}
43
47
}
···
55
59
return 'fa-plus';
56
60
case self::TYPE_COMMAND:
57
61
switch ($new) {
58
-
case HarbormasterBuildCommand::COMMAND_RESTART:
62
+
case HarbormasterBuildMessageRestartTransaction::MESSAGETYPE:
59
63
return 'fa-backward';
60
-
case HarbormasterBuildCommand::COMMAND_RESUME:
64
+
case HarbormasterBuildMessageResumeTransaction::MESSAGETYPE:
61
65
return 'fa-play';
62
-
case HarbormasterBuildCommand::COMMAND_PAUSE:
66
+
case HarbormasterBuildMessagePauseTransaction::MESSAGETYPE:
63
67
return 'fa-pause';
68
+
case HarbormasterBuildMessageAbortTransaction::MESSAGETYPE:
69
+
return 'fa-exclamation-triangle';
64
70
}
65
71
}
66
72
···
78
84
return 'green';
79
85
case self::TYPE_COMMAND:
80
86
switch ($new) {
81
-
case HarbormasterBuildCommand::COMMAND_PAUSE:
87
+
case HarbormasterBuildMessagePauseTransaction::MESSAGETYPE:
82
88
return 'red';
83
89
}
84
90
}
+4
-4
src/applications/harbormaster/storage/build/HarbormasterBuild.php
+4
-4
src/applications/harbormaster/storage/build/HarbormasterBuild.php
···
272
272
foreach ($this->getUnprocessedMessages() as $message_object) {
273
273
$message_type = $message_object->getType();
274
274
switch ($message_type) {
275
-
case HarbormasterBuildCommand::COMMAND_RESTART:
275
+
case HarbormasterBuildMessageRestartTransaction::MESSAGETYPE:
276
276
$is_restarting = true;
277
277
$is_aborting = false;
278
278
$apply_messages = array($message_object);
279
279
break;
280
-
case HarbormasterBuildCommand::COMMAND_ABORT:
280
+
case HarbormasterBuildMessageAbortTransaction::MESSAGETYPE:
281
281
$is_aborting = true;
282
282
$is_restarting = false;
283
283
$apply_messages = array($message_object);
284
284
break;
285
-
case HarbormasterBuildCommand::COMMAND_PAUSE:
285
+
case HarbormasterBuildMessagePauseTransaction::MESSAGETYPE:
286
286
$is_pausing = true;
287
287
$is_resuming = false;
288
288
$apply_messages = array($message_object);
289
289
break;
290
-
case HarbormasterBuildCommand::COMMAND_RESUME:
290
+
case HarbormasterBuildMessageResumeTransaction::MESSAGETYPE:
291
291
$is_resuming = true;
292
292
$is_pausing = false;
293
293
$apply_messages = array($message_object);