@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Surface custom form instructions as a "Remarkup" field for the transaction layer
Summary: Ref T13263. See <https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594>. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so `{Fxxx}` references don't get attached correctly and won't get proper permissions.
Test Plan:
Dragged-and-dropped an image into form instructions, saw the file attach to the form:
{F6367710}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13263
Differential Revision: https://secure.phabricator.com/D20387
+14
+14
src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php
+14
src/applications/transactions/storage/PhabricatorEditEngineConfigurationTransaction.php
···
149
149
return parent::getIcon();
150
150
}
151
151
152
+
protected function newRemarkupChanges() {
153
+
$changes = array();
154
+
155
+
$type = $this->getTransactionType();
156
+
switch ($type) {
157
+
case self::TYPE_PREAMBLE:
158
+
$changes[] = $this->newRemarkupChange()
159
+
->setOldValue($this->getOldValue())
160
+
->setNewValue($this->getNewValue());
161
+
break;
162
+
}
163
+
164
+
return $changes;
165
+
}
152
166
153
167
}