recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: DifferentialRevisionViewController: Do not pass null array key

Summary:
Same game as D26531.

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/differential/controller/DifferentialRevisionViewController.php:1480]

ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/differential/controller/DifferentialRevisionViewController.php:1504]
```

Closes T16363

Test Plan: Go to a Differential revision like http://phorge.localhost/D1

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16363

Differential Revision: https://we.phorge.it/D26532

Andre Klapper 1a6a64f5 ee476ee6

+2 -2
+2 -2
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 1477 1477 } 1478 1478 } 1479 1479 1480 - if (isset($diffs[$old_id])) { 1480 + if ($old_id && isset($diffs[$old_id])) { 1481 1481 return $old_id; 1482 1482 } 1483 1483 ··· 1501 1501 return new Aphront404Response(); 1502 1502 } 1503 1503 1504 - if (isset($diffs[$new_id])) { 1504 + if ($new_id && isset($diffs[$new_id])) { 1505 1505 return $new_id; 1506 1506 } 1507 1507