recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Deduplicating duplicated field values for Commit Messages / Differential

Summary: Especially when doing 'arc diff' containing multiple commits which have pre-filled template fields. Names would pop up multiple times

Test Plan:
{F36314}

Local `arc diff` with some uber-branch also agrees with me

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5371

authored by

Anh Nhan Nguyen and committed by
epriestley 1a92976c 23d72d7e

+3 -3
+1 -1
src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
··· 73 73 } 74 74 75 75 public function setValueFromParsedCommitMessage($value) { 76 - $this->ccs = nonempty($value, array()); 76 + $this->ccs = array_unique(nonempty($value), array()); 77 77 return $this; 78 78 } 79 79
+1 -1
src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php
··· 92 92 } 93 93 94 94 public function setValueFromParsedCommitMessage($value) { 95 - $this->maniphestTasks = nonempty($value, array()); 95 + $this->maniphestTasks = array_unique(nonempty($value), array()); 96 96 return $this; 97 97 } 98 98
+1 -1
src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
··· 91 91 } 92 92 93 93 public function setValueFromParsedCommitMessage($value) { 94 - $this->reviewers = nonempty($value, array()); 94 + $this->reviewers = array_unique(nonempty($value), array()); 95 95 return $this; 96 96 } 97 97