@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Differential transaction strengths
Summary: Fixes T4899. Action strengths got lost somewhere along the way; actions like "Accepted" should be stronger than "Changed Subscribers".
Test Plan: Verified things sort as expected now, with major actions at the top.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T4899
Differential Revision: https://secure.phabricator.com/D8857
+15
+15
src/applications/differential/storage/DifferentialTransaction.php
+15
src/applications/differential/storage/DifferentialTransaction.php
···
112
112
return $phids;
113
113
}
114
114
115
+
public function getActionStrength() {
116
+
117
+
switch ($this->getTransactionType()) {
118
+
case self::TYPE_ACTION:
119
+
return 3;
120
+
case self::TYPE_UPDATE:
121
+
return 2;
122
+
case self::TYPE_INLINE:
123
+
return 0.25;
124
+
}
125
+
126
+
return parent::getActionStrength();
127
+
}
128
+
129
+
115
130
public function getActionName() {
116
131
switch ($this->getTransactionType()) {
117
132
case self::TYPE_INLINE: