@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some format strings
Summary: These format strings use `%d` instead of `%s`.
Test Plan: Eyeball it.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12996
+5
-6
+1
-2
src/applications/differential/parser/DifferentialChangesetParser.php
+1
-2
src/applications/differential/parser/DifferentialChangesetParser.php
···
906
906
$shield = $renderer->renderShield(
907
907
pht('This file was completely deleted.'));
908
908
} else if ($this->changeset->getAffectedLineCount() > 2500) {
909
-
$lines = number_format($this->changeset->getAffectedLineCount());
910
909
$shield = $renderer->renderShield(
911
910
pht(
912
911
'This file has a very large number of changes (%s lines).',
913
-
$lines));
912
+
new PhutilNumber($this->changeset->getAffectedLineCount())));
914
913
}
915
914
}
916
915
+2
-2
src/applications/diffusion/controller/DiffusionCommitController.php
+2
-2
src/applications/diffusion/controller/DiffusionCommitController.php
···
240
240
241
241
$change_panel = new PHUIObjectBoxView();
242
242
$header = new PHUIHeaderView();
243
-
$header->setHeader(pht('Changes (%d', number_format($count)));
243
+
$header->setHeader(pht('Changes (%s)', new PhutilNumber($count)));
244
244
$change_panel->setID('toc');
245
-
if ($count > self::CHANGES_LIMIT && !$show_all_details) {
246
245
246
+
if ($count > self::CHANGES_LIMIT && !$show_all_details) {
247
247
$icon = id(new PHUIIconView())
248
248
->setIconFont('fa-files-o');
249
249
+2
-2
src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
+2
-2
src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php
···
241
241
'**NOTE**: This script will queue tasks to reparse the data. Once the '.
242
242
'tasks have been queued, you need to run Taskmaster daemons to '.
243
243
'execute them.'."\n\n".
244
-
"QUEUEING TASKS (%d Commits):",
245
-
number_format(count($commits))));
244
+
"QUEUEING TASKS (%s Commits):",
245
+
new PhutilNumber(count($commits))));
246
246
}
247
247
248
248
$progress = new PhutilConsoleProgressBar();