recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception which blocks rendering Pholio mock preview

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15353

Test Plan: Applied this change and `/pholio/create/` displayed an image preview after uploading an image file.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15353

Differential Revision: https://we.phorge.it/D25193

Andre Klapper 1b4015d2 e9e2c954

+1 -1
+1 -1
src/applications/pholio/controller/PholioImageUploadController.php
··· 18 18 return new Aphront404Response(); 19 19 } 20 20 21 - if (!strlen($title)) { 21 + if (!phutil_nonempty_string($title)) { 22 22 $title = $file->getName(); 23 23 } 24 24