@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with rendering some commit hovercards
Summary: This logic wasn't quite right.
Test Plan: Hovered over a recognized commit, got a valid hovercard
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D14925
+1
-1
+1
-1
src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php
+1
-1
src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php
···
28
28
29
29
$author_phid = $commit->getAuthorPHID();
30
30
if ($author_phid) {
31
-
$author = $viewer->loadHandle($author)->renderLink();
31
+
$author = $viewer->renderHandle($author_phid);
32
32
} else {
33
33
$commit_data = $commit->loadCommitData();
34
34
$author = phutil_tag('em', array(), $commit_data->getAuthorName());