recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

avoid claiming that the source of a file move was unchanged

Summary:
sometimes we show moved files as unchanged, sometimes deleted,
and sometimes inconsistent with what actually happened at the
destination of the move. Rather than make a false claim,
omit the 'not changed' notice if this is the source of a move.

Background: one of our users was confused by the source of a move
claiming to be unmodified when the destination of the move had
extensive modifications.

There may be a question about the quality of the data we keep/compute
about the changes, so maybe we could do a better or more consistent
job there (may just be nuances of the SCM in use); this approach
just smoothes that out and doesn't require fixing up the status
in pre-existing diffs.

Test Plan:
In the facebook phabricator, D594195#739ace1a and D590020#b97cfcfd
For others, find a diff that has moved files.
For the source of a move, we should now only show the "X moved to Y"
header and not the "unchanged" shield.

Reviewers: nh, vrana, epriestley

Reviewed By: vrana

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3669

Wez Furlong 1b6eced7 4b4e140f

+8
+8
src/applications/differential/parser/DifferentialChangesetParser.php
··· 446 446 $unchanged = true; 447 447 } 448 448 } 449 + $changetype = $this->changeset->getChangeType(); 450 + if ($changetype == DifferentialChangeType::TYPE_MOVE_AWAY) { 451 + // sometimes we show moved files as unchanged, sometimes deleted, 452 + // and sometimes inconsistent with what actually happened at the 453 + // destination of the move. Rather than make a false claim, 454 + // omit the 'not changed' notice if this is the source of a move 455 + $unchanged = false; 456 + } 449 457 450 458 $this->specialAttributes = array( 451 459 self::ATTR_UNCHANGED => $unchanged,