@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
In Diviner, parse "abstract" and "final" in PHP classes, interfaces and methods
Summary: Ref T988. Adds support for the "abstract" and "final" keywords in the atomizer.
Test Plan: Looked at abstract/final stuff.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T988
Differential Revision: https://secure.phabricator.com/D6850
+5
-1
+5
-1
src/applications/diviner/atomizer/DivinerPHPAtomizer.php
+5
-1
src/applications/diviner/atomizer/DivinerPHPAtomizer.php
···
49
49
->setFile($file_name)
50
50
->setLine($class->getLineNumber());
51
51
52
-
// TODO: Parse "abstract" and "final".
52
+
// This parses "final" and "abstract".
53
+
$attributes = $class->getChildByIndex(0, 'n_CLASS_ATTRIBUTES');
54
+
foreach ($attributes->selectDescendantsOfType('n_STRING') as $attr) {
55
+
$atom->setProperty($attr->getConcreteString(), true);
56
+
}
53
57
54
58
// If this exists, it is n_EXTENDS_LIST.
55
59
$extends = $class->getChildByIndex(2);