@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Disallow "Accept" on drafts, allow "Resign"
Summary:
Depends on D18801. Ref T2543. See PHI229. I missed "Accept" before, but intended to disallow it (like "Reject") since I don't want drafts to be reviewable.
However, "Resign" seems fine to allow? So let's allow that for now.
Test Plan: Was no longer offered "Accept" on draft revisions.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T2543
Differential Revision: https://secure.phabricator.com/D18802
+5
-5
+5
src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
+5
src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
···
162
162
'closed. Only open revisions can be accepted.'));
163
163
}
164
164
165
+
if ($object->isDraft()) {
166
+
throw new Exception(
167
+
pht('You can not accept a draft revision.'));
168
+
}
169
+
165
170
$config_key = 'differential.allow-self-accept';
166
171
if (!PhabricatorEnv::getEnvConfig($config_key)) {
167
172
if ($this->isViewerRevisionAuthor($object, $viewer)) {
-5
src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
-5
src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
···
64
64
'been closed. You can only resign from open revisions.'));
65
65
}
66
66
67
-
if ($object->isDraft()) {
68
-
throw new Exception(
69
-
pht('You can not resign from a draft revision.'));
70
-
}
71
-
72
67
$resigned = DifferentialReviewerStatus::STATUS_RESIGNED;
73
68
if ($this->getViewerReviewerStatus($object, $viewer) == $resigned) {
74
69
throw new Exception(