recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fixes T2523 - Comments are being displayed in feed.

Summary:
currently, only comments per se are being displayed. cut after 128 characters (which is the default), means in theory up to 128 newlines ^^

when you for example claim a task with a comment, close it with a comment, or do anything else, it won't be displayed

Test Plan: {F33890}

Reviewers: epriestley, btrahan, hwinkel

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2523

Differential Revision: https://secure.phabricator.com/D5119

authored by

Anh Nhan Nguyen and committed by
epriestley 1b8ac077 34db006c

+15 -1
+15 -1
src/applications/feed/story/PhabricatorFeedStoryManiphest.php
··· 26 26 $action = $data->getValue('action'); 27 27 switch ($action) { 28 28 case ManiphestAction::ACTION_CREATE: 29 + case ManiphestAction::ACTION_COMMENT: 29 30 $full_size = true; 30 31 break; 31 32 default: ··· 35 36 36 37 if ($full_size) { 37 38 $view->setImage($this->getHandle($data->getAuthorPHID())->getImageURI()); 38 - $content = $this->renderSummary($data->getValue('description')); 39 + 40 + switch ($action) { 41 + case ManiphestAction::ACTION_COMMENT: 42 + // I'm just fetching the comments here 43 + // Don't repeat this at home! 44 + $comments = $data->getValue('comments'); 45 + $content = $this->renderSummary($comments); 46 + break; 47 + default: 48 + // I think this is just for create 49 + $content = $this->renderSummary($data->getValue('description')); 50 + break; 51 + } 52 + 39 53 $view->appendChild($content); 40 54 } else { 41 55 $view->setOneLineStory(true);