recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception which blocks rendering MFA Provider page

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15386

Test Plan: Applied this change, afterwards page "Mobile Phone App (TOTP)" at `/auth/mfa/4/` renders in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15386

Differential Revision: https://we.phorge.it/D25218

Andre Klapper 1b905706 bff0f810

+1 -1
+1 -1
src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php
··· 83 83 84 84 85 85 $custom_enroll = $provider->getEnrollMessage(); 86 - if (strlen($custom_enroll)) { 86 + if (phutil_nonempty_string($custom_enroll)) { 87 87 $view->addSectionHeader( 88 88 pht('Custom Enroll Message'), 89 89 PHUIPropertyListView::ICON_SUMMARY);