recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix some PHP 8.1 issues in Diviner generator

Summary:
After this change I was able to generate again the Diviner
documentation from PHP 8.2 using the related command:

./bin/diviner generate

Closes T15255

Test Plan:
- run `./bin/diviner generate` - great success
- tested the advanced search in various ways - it still works

Reviewers: O1 Blessed Committers, Matthew

Reviewed By: O1 Blessed Committers, Matthew

Subscribers: Ekubischta, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15226, T15255

Differential Revision: https://we.phorge.it/D25124

Valerio Bozzolan 1ba5c8c2 996a853f

+4 -4
+2 -2
src/applications/diviner/query/DivinerBookQuery.php
··· 133 133 $this->phids); 134 134 } 135 135 136 - if (strlen($this->nameLike)) { 136 + if (phutil_nonempty_string($this->nameLike)) { 137 137 $where[] = qsprintf( 138 138 $conn, 139 139 'name LIKE %~', ··· 147 147 $this->names); 148 148 } 149 149 150 - if (strlen($this->namePrefix)) { 150 + if (phutil_nonempty_string($this->namePrefix)) { 151 151 $where[] = qsprintf( 152 152 $conn, 153 153 'name LIKE %>',
+1 -1
src/applications/diviner/storage/DivinerLiveSymbol.php
··· 182 182 public function setTitle($value) { 183 183 $this->writeField('title', $value); 184 184 185 - if (strlen($value)) { 185 + if (phutil_nonempty_string($value)) { 186 186 $slug = DivinerAtomRef::normalizeTitleString($value); 187 187 $hash = PhabricatorHash::digestForIndex($slug); 188 188 $this->titleSlugHash = $hash;
+1 -1
src/applications/diviner/workflow/DivinerGenerateWorkflow.php
··· 194 194 195 195 $identifier = $args->getArg('repository'); 196 196 $repository = null; 197 - if (strlen($identifier)) { 197 + if (phutil_nonempty_string($identifier)) { 198 198 $repository = id(new PhabricatorRepositoryQuery()) 199 199 ->setViewer(PhabricatorUser::getOmnipotentUser()) 200 200 ->withIdentifiers(array($identifier))