@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

In Conpherence, stop throwing away stuff users have typed when a reply arrives

Summary:
Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

- Add a `sleep(3)` to `UpdateController`.
- Type "AAA".
- Press enter.
- Real fast, type "BBB".
- When the "AAA" arrives, your "BBB" is lost. Sad!

Test Plan:
- Did the thing described above; no longer lost "BBB".
- Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12562

Differential Revision: https://secure.phabricator.com/D17742

+17 -18
+17 -17
resources/celerity/map.php
··· 8 8 return array( 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '3776e82d', 11 - 'conpherence.pkg.js' => '5f86c17d', 11 + 'conpherence.pkg.js' => '7b6aa581', 12 12 'core.pkg.css' => '959330a2', 13 13 'core.pkg.js' => '47a69358', 14 14 'darkconsole.pkg.js' => '1f9a31bc', ··· 378 378 'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '4d863052', 379 379 'rsrc/js/application/conpherence/behavior-conpherence-search.js' => '9bbf3762', 380 380 'rsrc/js/application/conpherence/behavior-durable-column.js' => 'aa3bd034', 381 - 'rsrc/js/application/conpherence/behavior-menu.js' => '80dda04a', 381 + 'rsrc/js/application/conpherence/behavior-menu.js' => '31ab6d0f', 382 382 'rsrc/js/application/conpherence/behavior-participant-pane.js' => '8604caa8', 383 383 'rsrc/js/application/conpherence/behavior-pontificate.js' => '55616e04', 384 384 'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3', ··· 605 605 'javelin-behavior-choose-control' => '327a00d1', 606 606 'javelin-behavior-comment-actions' => '9a6dd75c', 607 607 'javelin-behavior-config-reorder-fields' => 'b6993408', 608 - 'javelin-behavior-conpherence-menu' => '80dda04a', 608 + 'javelin-behavior-conpherence-menu' => '31ab6d0f', 609 609 'javelin-behavior-conpherence-participant-pane' => '8604caa8', 610 610 'javelin-behavior-conpherence-pontificate' => '55616e04', 611 611 'javelin-behavior-conpherence-search' => '9bbf3762', ··· 1126 1126 '31420f77' => array( 1127 1127 'javelin-behavior', 1128 1128 ), 1129 + '31ab6d0f' => array( 1130 + 'javelin-behavior', 1131 + 'javelin-dom', 1132 + 'javelin-util', 1133 + 'javelin-stratcom', 1134 + 'javelin-workflow', 1135 + 'javelin-behavior-device', 1136 + 'javelin-history', 1137 + 'javelin-vector', 1138 + 'javelin-scrollbar', 1139 + 'phabricator-title', 1140 + 'phabricator-shaped-request', 1141 + 'conpherence-thread-manager', 1142 + ), 1129 1143 '320810c8' => array( 1130 1144 'javelin-install', 1131 1145 'javelin-dom', ··· 1531 1545 'javelin-util', 1532 1546 'javelin-vector', 1533 1547 'javelin-stratcom', 1534 - ), 1535 - '80dda04a' => array( 1536 - 'javelin-behavior', 1537 - 'javelin-dom', 1538 - 'javelin-util', 1539 - 'javelin-stratcom', 1540 - 'javelin-workflow', 1541 - 'javelin-behavior-device', 1542 - 'javelin-history', 1543 - 'javelin-vector', 1544 - 'javelin-scrollbar', 1545 - 'phabricator-title', 1546 - 'phabricator-shaped-request', 1547 - 'conpherence-thread-manager', 1548 1548 ), 1549 1549 '834a1173' => array( 1550 1550 'javelin-behavior',
-1
webroot/rsrc/js/application/conpherence/behavior-menu.js
··· 70 70 var textarea = JX.DOM.find(form_root, 'textarea'); 71 71 if (!non_update) { 72 72 _scrollMessageWindow(); 73 - textarea.value = ''; 74 73 } 75 74 markThreadLoading(false); 76 75