@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove two unused SearchEngine methods
Summary:
Ref T11326. These are last-generation and neither of these have callsites anymore.
(I nuked these since I'm trying to simplify date handling.)
Test Plan: Grepped for callsites.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11326
Differential Revision: https://secure.phabricator.com/D16301
-57
-57
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
-57
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
···
713
713
714
714
715
715
/**
716
-
* Read a list of project PHIDs from a request in a flexible way.
717
-
*
718
-
* @param AphrontRequest Request to read user PHIDs from.
719
-
* @param string Key to read in the request.
720
-
* @return list<phid> List of projet PHIDs and selector functions.
721
-
* @task read
722
-
*/
723
-
protected function readProjectsFromRequest(AphrontRequest $request, $key) {
724
-
$list = $this->readListFromRequest($request, $key);
725
-
726
-
$phids = array();
727
-
$slugs = array();
728
-
$project_type = PhabricatorProjectProjectPHIDType::TYPECONST;
729
-
foreach ($list as $item) {
730
-
$type = phid_get_type($item);
731
-
if ($type == $project_type) {
732
-
$phids[] = $item;
733
-
} else {
734
-
if (PhabricatorTypeaheadDatasource::isFunctionToken($item)) {
735
-
// If this is a function, pass it through unchanged; we'll evaluate
736
-
// it later.
737
-
$phids[] = $item;
738
-
} else {
739
-
$slugs[] = $item;
740
-
}
741
-
}
742
-
}
743
-
744
-
if ($slugs) {
745
-
$projects = id(new PhabricatorProjectQuery())
746
-
->setViewer($this->requireViewer())
747
-
->withSlugs($slugs)
748
-
->execute();
749
-
foreach ($projects as $project) {
750
-
$phids[] = $project->getPHID();
751
-
}
752
-
$phids = array_unique($phids);
753
-
}
754
-
755
-
return $phids;
756
-
}
757
-
758
-
759
-
/**
760
716
* Read a list of subscribers from a request in a flexible way.
761
717
*
762
718
* @param AphrontRequest Request to read PHIDs from.
···
847
803
}
848
804
849
805
return $list;
850
-
}
851
-
852
-
protected function readDateFromRequest(
853
-
AphrontRequest $request,
854
-
$key) {
855
-
856
-
$value = AphrontFormDateControlValue::newFromRequest($request, $key);
857
-
858
-
if ($value->isEmpty()) {
859
-
return null;
860
-
}
861
-
862
-
return $value->getDictionary();
863
806
}
864
807
865
808
protected function readBoolFromRequest(