@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix "not(project)" in Diffusion
Summary: Fixes T8105. We weren't including the parent WHERE clause fragment correctly.
Test Plan: Used `not(project)` in a query.
Reviewers: btrahan, avivey
Reviewed By: avivey
Subscribers: avivey, epriestley
Maniphest Tasks: T8105
Differential Revision: https://secure.phabricator.com/D12746
+3
-9
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
102
102
'AphrontApplicationConfiguration' => 'aphront/configuration/AphrontApplicationConfiguration.php',
103
103
'AphrontBarView' => 'view/widget/bars/AphrontBarView.php',
104
104
'AphrontCSRFException' => 'aphront/exception/AphrontCSRFException.php',
105
-
'AphrontCalendarDayEventView' => 'applications/calendar/view/AphrontCalendarDayEventView.php',
106
105
'AphrontCalendarEventView' => 'applications/calendar/view/AphrontCalendarEventView.php',
107
106
'AphrontController' => 'aphront/AphrontController.php',
108
107
'AphrontCursorPagerView' => 'view/control/AphrontCursorPagerView.php',
···
3352
3351
'AphrontAjaxResponse' => 'AphrontResponse',
3353
3352
'AphrontBarView' => 'AphrontView',
3354
3353
'AphrontCSRFException' => 'AphrontException',
3355
-
'AphrontCalendarDayEventView' => 'AphrontView',
3356
3354
'AphrontCalendarEventView' => 'AphrontView',
3357
3355
'AphrontController' => 'Phobject',
3358
3356
'AphrontCursorPagerView' => 'AphrontView',
+3
-7
src/applications/repository/query/PhabricatorRepositoryQuery.php
+3
-7
src/applications/repository/query/PhabricatorRepositoryQuery.php
···
429
429
return false;
430
430
}
431
431
432
-
protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
433
-
$where = array();
432
+
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn_r) {
433
+
$where = parent::buildWhereClauseParts($conn_r);
434
434
435
435
if ($this->ids) {
436
436
$where[] = qsprintf(
···
518
518
$callsign);
519
519
}
520
520
521
-
$where[] = $this->buildPagingClause($conn_r);
522
-
523
-
return $this->formatWhereClause($where);
521
+
return $where;
524
522
}
525
-
526
-
527
523
528
524
public function getQueryApplicationClass() {
529
525
return 'PhabricatorDiffusionApplication';