@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Tighten a regular expression in `repository.create`
Summary:
See <https://github.com/facebook/phabricator/issues/433>. We were missing a "^" here.
This should be moved over to transactions soon and then we can get rid of the duplication. :/
Test Plan: Tried to create a repository with callsign "9X", got a helpful error about "ALL UPPERCASE LETTERS".
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7531
+1
-1
+1
-1
src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
+1
-1
src/applications/repository/conduit/ConduitAPI_repository_create_Method.php
···
83
83
$repository->setName($request->getValue('name'));
84
84
85
85
$callsign = $request->getValue('callsign');
86
-
if (!preg_match('/[A-Z]+$/', $callsign)) {
86
+
if (!preg_match('/^[A-Z]+$/', $callsign)) {
87
87
throw new ConduitException('ERR-BAD-CALLSIGN');
88
88
}
89
89
$repository->setCallsign($callsign);