@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When using "Update Diff" from the web UI, prefill "Repository" properly
Summary: Ref T9499. When using the manual "Update Diff" workflow on the web, the "Repository" field isn't pre-filled properly. This can lead to revisions losing their repository after a manual update.
Test Plan: Did a manual update of a revision with a repository, saw it stick.
Maniphest Tasks: T9499
Differential Revision: https://secure.phabricator.com/D21638
+7
-1
+7
-1
src/applications/differential/controller/DifferentialDiffCreateController.php
+7
-1
src/applications/differential/controller/DifferentialDiffCreateController.php
···
27
27
$diff = null;
28
28
// This object is just for policy stuff
29
29
$diff_object = DifferentialDiff::initializeNewDiff($viewer);
30
-
$repository_phid = null;
30
+
31
+
if ($revision) {
32
+
$repository_phid = $revision->getRepositoryPHID();
33
+
} else {
34
+
$repository_phid = null;
35
+
}
36
+
31
37
$errors = array();
32
38
$e_diff = null;
33
39
$e_file = null;